Re: [PATCH] Make inlining consistent in LTO and non-LTO mode (PR target/71991).

2017-11-03 Thread Martin Liška
Hi. Honza can you please take a look at this, because Richi installed patch that I originally suggested and you were not happy about: r251333. Thanks, Martin

Re: [PATCH] Make inlining consistent in LTO and non-LTO mode (PR target/71991).

2017-08-15 Thread Martin Liška
On 08/10/2017 03:39 PM, Jan Hubicka wrote: >>> - /* If callee has no option attributes, then it is ok to inline. */ >>> - if (!callee_tree) >>> + /* If callee has no option attributes (or default), >>> + then it is ok to inline. */ >>> + if (!callee_tree || callee_tree

Re: [PATCH] Make inlining consistent in LTO and non-LTO mode (PR target/71991).

2017-08-10 Thread Jan Hubicka
> > - /* If callee has no option attributes, then it is ok to inline. */ > > - if (!callee_tree) > > + /* If callee has no option attributes (or default), > > + then it is ok to inline. */ > > + if (!callee_tree || callee_tree == target_option_default_node) > > >>

Re: [PATCH] Make inlining consistent in LTO and non-LTO mode (PR target/71991).

2017-07-31 Thread Martin Liška
Honza? Thanks, Martin On 06/30/2017 03:50 PM, Martin Liška wrote: > On 06/28/2017 05:18 PM, Jan Hubicka wrote: >>> On 06/28/2017 04:24 PM, Jan Hubicka wrote: > - /* If callee has no option attributes, then it is ok to inline. */ > - if (!callee_tree) > + /* If callee has no option

Re: [PATCH] Make inlining consistent in LTO and non-LTO mode (PR target/71991).

2017-06-30 Thread Martin Liška
On 06/28/2017 05:18 PM, Jan Hubicka wrote: >> On 06/28/2017 04:24 PM, Jan Hubicka wrote: - /* If callee has no option attributes, then it is ok to inline. */ - if (!callee_tree) + /* If callee has no option attributes (or default), + then it is ok to inline. */ +

Re: [PATCH] Make inlining consistent in LTO and non-LTO mode (PR target/71991).

2017-06-28 Thread Jan Hubicka
> On 06/28/2017 04:24 PM, Jan Hubicka wrote: > >> - /* If callee has no option attributes, then it is ok to inline. */ > >> - if (!callee_tree) > >> + /* If callee has no option attributes (or default), > >> + then it is ok to inline. */ > >> + if (!callee_tree || callee_tree == target_op

Re: [PATCH] Make inlining consistent in LTO and non-LTO mode (PR target/71991).

2017-06-28 Thread Martin Liška
On 06/28/2017 04:24 PM, Jan Hubicka wrote: >> - /* If callee has no option attributes, then it is ok to inline. */ >> - if (!callee_tree) >> + /* If callee has no option attributes (or default), >> + then it is ok to inline. */ >> + if (!callee_tree || callee_tree == target_option_default

Re: [PATCH] Make inlining consistent in LTO and non-LTO mode (PR target/71991).

2017-06-28 Thread Jan Hubicka
> - /* If callee has no option attributes, then it is ok to inline. */ > - if (!callee_tree) > + /* If callee has no option attributes (or default), > + then it is ok to inline. */ > + if (!callee_tree || callee_tree == target_option_default_node) I am not sure this actually makes sense,