Re: [PATCH] Make all usage of "input_location" be explicit

2013-07-02 Thread Manuel López-Ibáñez
> Echoing Tom's question: given that last 2011 commit for improved macro > diagnostics which appears to assume a diagnostic->location, is it > reasonable to expect every call to diagnostic_report_current_function > call to have the right filename for diagnostic->location for the lang > hook? Not o

Re: [PATCH] Make all usage of "input_location" be explicit

2013-07-02 Thread David Malcolm
On Tue, 2013-07-02 at 10:33 -0600, Tom Tromey wrote: > > "David" == David Malcolm writes: > > David> gcc/java/ > David> 2013-07-02 David Malcolm > David>* class.c (maybe_layout_super_class): Update comment. > David>* decl.c (java_add_stmt): Remove use of input_filename macr

Re: [PATCH] Make all usage of "input_location" be explicit

2013-07-02 Thread Tom Tromey
> "David" == David Malcolm writes: David> gcc/java/ David> 2013-07-02 David Malcolm David> * class.c (maybe_layout_super_class): Update comment. David> * decl.c (java_add_stmt): Remove use of input_filename macro. David> * jcf-parse.c (set_source_filename): Remove use of David> input_f