Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-27 Thread Thomas Rodgers
Jonathan Wakely writes: > On 27/03/19 15:51 +0100, Thomas Schwinge wrote: >>Hi! >> >>If that's of any help to document the version dependencies: > > Thanks for t his. > >>On Fri, 22 Mar 2019 00:04:30 +, Jonathan Wakely >>wrote: >>> I keep forgetting to add that docs for this stuff will be

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-27 Thread Jonathan Wakely
On 27/03/19 15:51 +0100, Thomas Schwinge wrote: Hi! If that's of any help to document the version dependencies: Thanks for t his. On Fri, 22 Mar 2019 00:04:30 +, Jonathan Wakely wrote: I keep forgetting to add that docs for this stuff will be coming some time next week, describing the

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-27 Thread Thomas Schwinge
Hi! If that's of any help to document the version dependencies: On Fri, 22 Mar 2019 00:04:30 +, Jonathan Wakely wrote: > I keep forgetting to add that docs for this stuff will be coming some > time next week, describing the TBB dependency that's needed to use > these parallel algos. On an U

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-21 Thread Jonathan Wakely
On 21/03/19 23:56 +, Jonathan Wakely wrote: On 21/03/19 22:32 +, Jonathan Wakely wrote: On 21/03/19 15:19 -0700, Thomas Rodgers wrote: Fixed up change log. Thanks, this version seems to have addressed everything. As this was one of our big ticket features for stage 1 (but was delaye

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-21 Thread Jonathan Wakely
On 21/03/19 22:32 +, Jonathan Wakely wrote: On 21/03/19 15:19 -0700, Thomas Rodgers wrote: Fixed up change log. Thanks, this version seems to have addressed everything. As this was one of our big ticket features for stage 1 (but was delayed due to the necessary legal steps that Intel too

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-21 Thread Jonathan Wakely
On 21/03/19 15:19 -0700, Thomas Rodgers wrote: Fixed up change log. Thanks, this version seems to have addressed everything. As this was one of our big ticket features for stage 1 (but was delayed due to the necessary legal steps that Intel took to kindly transfer this to the LLVM project) we

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-21 Thread Thomas Rodgers
Fixed up change log. 20190321-1-pstl-integration.patch.bz2 Description: pstl integration patch Thomas Rodgers writes: > Jonathan Wakely writes: > >> On 20/03/19 14:05 -0700, Thomas Rodgers wrote: >> >>> >>>Fixed a failing test. >> >> Thanks. Apart from the changelog issue I mentioned on IRC, t

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-21 Thread Thomas Rodgers
20190321-pstl-integration.patch.bz2 Description: pstl integration patch Jonathan Wakely writes: > On 20/03/19 14:05 -0700, Thomas Rodgers wrote: > >> >>Fixed a failing test. > > Thanks. Apart from the changelog issue I mentioned on IRC, the only > other required change I see is in include/Makef

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-21 Thread Jonathan Wakely
On 21/03/19 11:37 +, Jonathan Wakely wrote: Exporting something like this from libstdc++.so would work, but is disgusting (and presumably "tbb::interface7" changes from release to release?"): extern "C" [[__gnu__::__weak__]] int _ZN3tbb10interface78internal15task_arena_base21internal_current

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-21 Thread Jonathan Wakely
On 20/03/19 14:05 -0700, Thomas Rodgers wrote: Fixed a failing test. Thanks. Apart from the changelog issue I mentioned on IRC, the only other required change I see is in include/Makefile.am: @@ -1480,7 +1512,9 @@ install-headers: $(mkinstalldirs) $(DESTDIR)${host_installdir}/../ext

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-20 Thread Thomas Rodgers
20190320-2-pstl-integration.patch.bz2 Description: Revised pstl integration patch Fixed a failing test. Thomas Rodgers writes: > This time with the changelog reflecting the updated files in include/std > > Thomas Rodgers writes: > >> See attached. >> >> Jonathan Wakely writes: >> >>> On 11/03/

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-20 Thread Thomas Rodgers
20190320-1-pstl-integration.patch.bz2 Description: Revised pstl integration patch This time with the changelog reflecting the updated files in include/std Thomas Rodgers writes: > See attached. > > Jonathan Wakely writes: > >> On 11/03/19 21:24 -0700, Thomas Rodgers wrote: >>>Let's try this pa

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-20 Thread Thomas Rodgers
See attached. 20190320-pstl-integration.patch.bz2 Description: revised pstl integration patch Jonathan Wakely writes: > On 11/03/19 21:24 -0700, Thomas Rodgers wrote: >>Let's try this patch - >> > > > The feature test macro should be 201603L (in and > ): > > +// Feature test macro for parallel

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-20 Thread Thomas Rodgers
Ignore Thomas Rodgers writes: > Jonathan Wakely writes: > >> On 11/03/19 21:24 -0700, Thomas Rodgers wrote: >>>Let's try this patch - >>> >> >> >> The feature test macro should be 201603L (in and >> ): >> >> +// Feature test macro for parallel algorithms >> +# define __cpp_lib_parallel_algorithm

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-20 Thread Ville Voutilainen
On Wed, 20 Mar 2019 at 22:15, Jakub Jelinek wrote: > > On Wed, Mar 20, 2019 at 09:13:42PM +0100, Jakub Jelinek wrote: > > On Wed, Mar 20, 2019 at 01:05:10PM -0700, Thomas Rodgers wrote: > > > > We only give that warning for C++11 headers, but for anything newer it > > > > should be just: > > > > >

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-20 Thread Jakub Jelinek
On Wed, Mar 20, 2019 at 09:13:42PM +0100, Jakub Jelinek wrote: > On Wed, Mar 20, 2019 at 01:05:10PM -0700, Thomas Rodgers wrote: > > > We only give that warning for C++11 headers, but for anything newer it > > > should be just: > > > > > > +#if __cplusplus >= 201703L > > > > Did you mean > > > >

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-20 Thread Jakub Jelinek
On Wed, Mar 20, 2019 at 01:05:10PM -0700, Thomas Rodgers wrote: > > We only give that warning for C++11 headers, but for anything newer it > > should be just: > > > > +#if __cplusplus >= 201703L > > Did you mean > > +#if __cplusplus >= 201603L I guess so: http://eel.is/c++draft/support.limits.ge

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-20 Thread Ville Voutilainen
On Wed, 20 Mar 2019 at 22:05, Thomas Rodgers wrote: > > +#if __cplusplus < 201703L > > +# include > > +#else > > > > We only give that warning for C++11 headers, but for anything newer it > > should be just: > > > > +#if __cplusplus >= 201703L > > Did you mean > > +#if __cplusplus >= 201603L > >

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-20 Thread Thomas Rodgers
Jonathan Wakely writes: > On 11/03/19 21:24 -0700, Thomas Rodgers wrote: >>Let's try this patch - >> > > > The feature test macro should be 201603L (in and > ): > > +// Feature test macro for parallel algorithms > +# define __cpp_lib_parallel_algorithm 201703L > > *** > > The new files have cop

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-19 Thread Jonathan Wakely
On 11/03/19 21:24 -0700, Thomas Rodgers wrote: Let's try this patch - The feature test macro should be 201603L (in and ): +// Feature test macro for parallel algorithms +# define __cpp_lib_parallel_algorithm 201703L *** The new files have copyright dates of 2018, but it's taken so long to

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-03-11 Thread Thomas Rodgers
Let's try this patch - 20190311-pstl-integration.patch.bz2 Description: pstl-integration-patch Jonathan Wakely writes: > On 31/01/19 21:08 -0800, Thomas Rodgers wrote: >>Update C++17 parallel algorithms to LLVM/MIT licensed upstream sources > > Some lines in bits/c++config.h need to be split b

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-02-07 Thread Thomas Rodgers
> We'll need to add a copy of the LICENSE.TXT file to our sources, since > it's referred to by the comments at the top of each PSTL file. > Right, we were going to discuss where the "right place" under libstdc++-v3/ would be for that. As for the rest, noted, I'll add them to the list for the next

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-02-07 Thread Jonathan Wakely
On 31/01/19 21:08 -0800, Thomas Rodgers wrote: Update C++17 parallel algorithms to LLVM/MIT licensed upstream sources Some lines in bits/c++config.h need to be split before 80 columns (with a backslash if the split is in the middle of a preprocessor condition obviously). There are loads of ver

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-02-04 Thread Thomas Rodgers
I will take another stab at un-nit-ing the changlog. Jakub Jelinek writes: > On Thu, Jan 31, 2019 at 09:08:52PM -0800, Thomas Rodgers wrote: >> Update C++17 parallel algorithms to LLVM/MIT licensed upstream sources > > Just ChangeLog formatting nits below: >> >> * include/Makefile.am:update

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-02-04 Thread Jakub Jelinek
On Thu, Jan 31, 2019 at 09:08:52PM -0800, Thomas Rodgers wrote: > Update C++17 parallel algorithms to LLVM/MIT licensed upstream sources Just ChangeLog formatting nits below: > > * include/Makefile.am:update from upstream > remove ${pstl_srcdir}/iterators.h > add

Re: [PATCH] Integration of parallel standard algorithms for c++17

2019-01-31 Thread Thomas Rodgers
Update C++17 parallel algorithms to LLVM/MIT licensed upstream sources * include/Makefile.am:update from upstream remove ${pstl_srcdir}/iterators.h add ${pstl_srcdir}/memory_impl.h * include/bits/c++config:update from upstream * include/pst

Re: [PATCH] Integration of parallel standard algorithms for c++17

2018-11-10 Thread Thomas Rodgers
This patch has been held up by licensing issues, specifically, awaiting upstream's plans to relicense the code from Apache 2.0 to the libc++ license - https://llvm.org/docs/DeveloperPolicy.html#license We expect the relicensing to conclude within the next few weeks. At that time I will be resub