Re: [PATCH] Improve ifcombine

2014-03-12 Thread Richard Biener
On March 12, 2014 10:52:23 AM CET, Jakub Jelinek wrote: >On Wed, Mar 12, 2014 at 09:51:46AM +0100, Richard Biener wrote: >> Ok in principle, but is there a possibility to factor this a bit? >> It looks like a lot of cut&paste (without looking too close for >subtle >> differences). > >Like this? Y

Re: [PATCH] Improve ifcombine

2014-03-12 Thread Jakub Jelinek
On Wed, Mar 12, 2014 at 09:51:46AM +0100, Richard Biener wrote: > Ok in principle, but is there a possibility to factor this a bit? > It looks like a lot of cut&paste (without looking too close for subtle > differences). Like this? 2014-03-12 Jakub Jelinek * tree-ssa-ifcombine.c (forw

Re: [PATCH] Improve ifcombine

2014-03-12 Thread Richard Biener
On Tue, 11 Mar 2014, Jakub Jelinek wrote: > Hi! > > This patch fixes the ssa-ifcombine-10.c regression. > The thing is that the uselessly added ASSERT_EXPR makes vrp1 change > the cfg slightly like this: >: >_4 = x_3(D) & 1; >if (_4 == 0) > goto ; >else > goto ; > >

Re: [PATCH] Improve ifcombine (PR 52005)

2012-08-06 Thread Richard Guenther
On Mon, Aug 6, 2012 at 8:27 AM, Marc Glisse wrote: > > Hello, > > do you have an opinion on this patch (available here: > http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01352.html > ) ? I like it. Thus, the referenced patch is ok for trunk. Thanks, Richard. > Or should we go back to my old patch

Re: [PATCH] Improve ifcombine (PR 52005)

2012-08-05 Thread Marc Glisse
Hello, do you have an opinion on this patch (available here: http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01352.html ) ? Or should we go back to my old patch, or Andrew's patch? On Thu, 26 Jul 2012, Marc Glisse wrote: Hello, here is a new version of the ifcombine patch, which handles Andrew

Re: [PATCH] Improve ifcombine (PR 52005)

2012-07-26 Thread Marc Glisse
Hello, here is a new version of the ifcombine patch, which handles Andrew's examples (though only with -O2 for one of them, same_phi_args_p returns false otherwise). Note that the new patch never calls maybe_fold_or_comparisons, only maybe_fold_and_comparisons. It would be possible to call

Re: [PATCH] Improve ifcombine (PR 52005)

2012-07-24 Thread Marc Glisse
On Tue, 24 Jul 2012, Andrew Pinski wrote: On Tue, Jul 24, 2012 at 2:37 AM, Richard Guenther wrote: On Tue, Jul 24, 2012 at 10:25 AM, Marc Glisse wrote: On Mon, 23 Jul 2012, Andrew Pinski wrote: This patch improves ifcombine by doing two things. First tries to see if the then and else are

Re: [PATCH] Improve ifcombine (PR 52005)

2012-07-24 Thread Andrew Pinski
On Tue, Jul 24, 2012 at 2:37 AM, Richard Guenther wrote: > On Tue, Jul 24, 2012 at 10:25 AM, Marc Glisse wrote: >> On Mon, 23 Jul 2012, Andrew Pinski wrote: >> >>> This patch improves ifcombine by doing two things. First tries to see >>> if the then and else are swapped and handles that case. >>

Re: [PATCH] Improve ifcombine (PR 52005)

2012-07-24 Thread Richard Guenther
On Tue, Jul 24, 2012 at 10:25 AM, Marc Glisse wrote: > On Mon, 23 Jul 2012, Andrew Pinski wrote: > >> This patch improves ifcombine by doing two things. First tries to see >> if the then and else are swapped and handles that case. > > > Just a few hours after I posted: > http://gcc.gnu.org/ml/gcc

Re: [PATCH] Improve ifcombine (PR 52005)

2012-07-24 Thread Marc Glisse
On Mon, 23 Jul 2012, Andrew Pinski wrote: This patch improves ifcombine by doing two things. First tries to see if the then and else are swapped and handles that case. Just a few hours after I posted: http://gcc.gnu.org/ml/gcc-patches/2012-07/msg01160.html Could you check that your patch wor