Re: [PATCH] Hashtable PR96088

2021-06-02 Thread Jonathan Wakely via Gcc-patches
On 01/06/21 19:10 +0100, Jonathan Wakely wrote: On 01/06/21 18:47 +0100, Jonathan Wakely wrote: On 01/06/21 18:45 +0100, Jonathan Wakely wrote: On 22/05/21 18:35 +0200, François Dumont wrote: diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc b/libstdc++-v3/testsuite/23_

Re: [PATCH] Hashtable PR96088

2021-06-01 Thread François Dumont via Gcc-patches
On 01/06/21 8:10 pm, Jonathan Wakely wrote: On 01/06/21 18:47 +0100, Jonathan Wakely wrote: On 01/06/21 18:45 +0100, Jonathan Wakely wrote: On 22/05/21 18:35 +0200, François Dumont wrote: diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc b/libstdc++-v3/testsuite/23_cont

Re: [PATCH] Hashtable PR96088

2021-06-01 Thread Jonathan Wakely via Gcc-patches
On 01/06/21 18:47 +0100, Jonathan Wakely wrote: On 01/06/21 18:45 +0100, Jonathan Wakely wrote: On 22/05/21 18:35 +0200, François Dumont wrote: diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc b/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc new file mode 1

Re: [PATCH] Hashtable PR96088

2021-06-01 Thread Jonathan Wakely via Gcc-patches
On 01/06/21 18:45 +0100, Jonathan Wakely wrote: On 22/05/21 18:35 +0200, François Dumont wrote: diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc b/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc new file mode 100644 index 000..53bb754dab6 --- /dev/nul

Re: [PATCH] Hashtable PR96088

2021-06-01 Thread Jonathan Wakely via Gcc-patches
On 22/05/21 18:35 +0200, François Dumont wrote: diff --git a/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc b/libstdc++-v3/testsuite/23_containers/unordered_set/96088.cc new file mode 100644 index 000..53bb754dab6 --- /dev/null +++ b/libstdc++-v3/testsuite/23_containers/unor

Re: [PATCH] Hashtable PR96088

2021-05-24 Thread Jonathan Wakely via Gcc-patches
On 22/05/21 18:35 +0200, François Dumont wrote: This was indeed the right approach.     The only minor drawback is that __is_noexcept_invocable<> combines noexcept qualification of the conversion and of the hash functor. So if the hash functor is not noexcept we could end up creating temporar

Re: [PATCH] Hashtable PR96088

2021-05-24 Thread Jonathan Wakely via Gcc-patches
On 24/05/21 11:31 +0200, François Dumont wrote: On 20/05/21 6:44 pm, Jonathan Wakely wrote: On 06/05/21 22:03 +0200, François Dumont via Libstdc++ wrote: Hi     Considering your feedback on backtrace in debug mode is going to take me some time so here is another one.     Compared to latest

Re: [PATCH] Hashtable PR96088

2021-05-24 Thread François Dumont via Gcc-patches
On 20/05/21 6:44 pm, Jonathan Wakely wrote: On 06/05/21 22:03 +0200, François Dumont via Libstdc++ wrote: Hi     Considering your feedback on backtrace in debug mode is going to take me some time so here is another one.     Compared to latest submission I've added a _Hash_arg_t partial spec

Re: [PATCH] Hashtable PR96088

2021-05-22 Thread François Dumont via Gcc-patches
This was indeed the right approach.     The only minor drawback is that __is_noexcept_invocable<> combines noexcept qualification of the conversion and of the hash functor. So if the hash functor is not noexcept we could end up creating temporaries for nothing.     So I've eventually used th

Re: [PATCH] Hashtable PR96088

2021-05-20 Thread Jonathan Wakely via Gcc-patches
On Fri, 21 May 2021, 07:48 Jonathan Wakely, wrote: > > > On Fri, 21 May 2021, 07:31 François Dumont via Libstdc++, < > libstd...@gcc.gnu.org> wrote: > >> On 20/05/21 6:44 pm, Jonathan Wakely wrote: >> > On 06/05/21 22:03 +0200, François Dumont via Libstdc++ wrote: >> >> Hi >> >> >> >> Conside

Re: [PATCH] Hashtable PR96088

2021-05-20 Thread Jonathan Wakely via Gcc-patches
On Fri, 21 May 2021, 07:31 François Dumont via Libstdc++, < libstd...@gcc.gnu.org> wrote: > On 20/05/21 6:44 pm, Jonathan Wakely wrote: > > On 06/05/21 22:03 +0200, François Dumont via Libstdc++ wrote: > >> Hi > >> > >> Considering your feedback on backtrace in debug mode is going to > >> take

Re: [PATCH] Hashtable PR96088

2021-05-20 Thread François Dumont via Gcc-patches
On 20/05/21 6:44 pm, Jonathan Wakely wrote: On 06/05/21 22:03 +0200, François Dumont via Libstdc++ wrote: Hi     Considering your feedback on backtrace in debug mode is going to take me some time so here is another one.     Compared to latest submission I've added a _Hash_arg_t partial spec

Re: [PATCH] Hashtable PR96088

2021-05-20 Thread Jonathan Wakely via Gcc-patches
On 06/05/21 22:03 +0200, François Dumont via Libstdc++ wrote: Hi     Considering your feedback on backtrace in debug mode is going to take me some time so here is another one.     Compared to latest submission I've added a _Hash_arg_t partial specialization for std::hash<>. It is not strictl

Re: [PATCH] Hashtable PR96088

2021-05-17 Thread François Dumont via Gcc-patches
Hi     No chance yet to review this proposal ? François On 06/05/21 10:03 pm, François Dumont wrote: Hi     Considering your feedback on backtrace in debug mode is going to take me some time so here is another one.     Compared to latest submission I've added a _Hash_arg_t partial special

Re: [PATCH] Hashtable PR96088

2021-05-06 Thread François Dumont via Gcc-patches
Hi     Considering your feedback on backtrace in debug mode is going to take me some time so here is another one.     Compared to latest submission I've added a _Hash_arg_t partial specialization for std::hash<>. It is not strictly necessary for the moment but when we will eventually remove

Re: [PATCH] Hashtable PR96088

2020-12-04 Thread François Dumont via Gcc-patches
Following submission of the heterogeneous lookup in unordered containers I rebased this patch on top of it. Appart from reducing its size because of some code reuse the heterogeneous lookup had no impact on this one. This is because when I cannot find out if conversion from inserted element ty

Re: [PATCH] Hashtable PR96088

2020-10-24 Thread François Dumont via Gcc-patches
Hi     Just a rebase of this patch. François On 17/10/20 6:21 pm, François Dumont wrote: I eventually would like to propose the following resolution. For multi-key containers I kept the same resolution build the node first and compute has code from the node key. For unique-key ones I chang