Re: [PATCH] Graphite cannot handle return stmt

2015-07-02 Thread Tobias Grosser
On 06/30/2015 10:50 PM, Aditya Kumar wrote: No regressions. 2015-06-29 Aditya Kumar Sebastian Pop * graphite-scop-detection.c (stmt_simple_for_scop_p): Bail out in case of a return statement. LGTM. Tobias

Re: [PATCH] Graphite cannot handle return stmt

2015-06-30 Thread Richard Biener
On Tue, Jun 30, 2015 at 8:12 AM, Tobias Grosser wrote: > On 06/30/2015 02:12 AM, Sebastian Pop wrote: >> >> On Mon, Jun 29, 2015 at 3:58 PM, Aditya Kumar wrote: >>> >>> No regressions. >>> >>> 2015-06-29 Aditya Kumar >>> Sebastian Pop >>> >>> * graphite-scop-detection.c

Re: [PATCH] Graphite cannot handle return stmt

2015-06-29 Thread Tobias Grosser
On 06/30/2015 02:12 AM, Sebastian Pop wrote: On Mon, Jun 29, 2015 at 3:58 PM, Aditya Kumar wrote: No regressions. 2015-06-29 Aditya Kumar Sebastian Pop * graphite-scop-detection.c (stmt_simple_for_scop_p): Bail out in case of a return statement. Looks good to me.

Re: [PATCH] Graphite cannot handle return stmt

2015-06-29 Thread Sebastian Pop
On Mon, Jun 29, 2015 at 3:58 PM, Aditya Kumar wrote: > No regressions. > > 2015-06-29 Aditya Kumar > Sebastian Pop > > * graphite-scop-detection.c (stmt_simple_for_scop_p): Bail out in > case of a return statement. Looks good to me. Tobi, do you see a good reason not to c