Re: [PATCH] Fix use of declare'd vars by routine procedures.

2016-02-01 Thread Jakub Jelinek
On Mon, Feb 01, 2016 at 10:00:51AM -0600, James Norris wrote: > +2016-01-XX James Norris It is February now ;) > @@ -8223,7 +8247,7 @@ gimplify_oacc_declare (tree *expr_p, gimple_seq *pre_p) > if (oacc_declare_returns == NULL) > oacc_declare_returns = new hash_map; >

Re: [PATCH] Fix use of declare'd vars by routine procedures.

2016-02-01 Thread James Norris
Hi! On 01/29/2016 02:31 AM, Jakub Jelinek wrote: On Thu, Jan 28, 2016 at 12:26:38PM -0600, James Norris wrote: I think the attached change is what you had in mind with regard to doing the check at gimplification time. Nope, this is still a wrong location for that. If you look at the next line

Re: [PATCH] Fix use of declare'd vars by routine procedures.

2016-01-29 Thread Jakub Jelinek
On Thu, Jan 28, 2016 at 12:26:38PM -0600, James Norris wrote: > I think the attached change is what you had in mind with > regard to doing the check at gimplification time. Nope, this is still a wrong location for that. If you look at the next line after the block you've added, you'll see if (gimp

Re: [PATCH] Fix use of declare'd vars by routine procedures.

2016-01-28 Thread James Norris
Jakub, On 01/22/2016 04:39 AM, Jakub Jelinek wrote: As for the extra error, I think it would be better to diagnose this during gimplification, that way you do it for all FEs, plus you have the omp context in there, etc. The error wording is weird, the diagnostic should make it clear use of wha

Re: [PATCH] Fix use of declare'd vars by routine procedures.

2016-01-22 Thread Jakub Jelinek
On Sun, Jan 17, 2016 at 05:01:24PM -0600, James Norris wrote: > The attached patch addresses the failure of declare-4 in the libgomp > testsuite. > The primary failure was the use a variable with a link clause for an OpenACC > routine function. The patch changes the test to use a create clause. Th