Re: [PATCH] Fix target clone indirection elimination.

2020-06-26 Thread Yichao Yu via Gcc-patches
On Fri, Jun 26, 2020 at 5:51 PM Jeff Law wrote: > > On Mon, 2020-06-22 at 11:24 +0200, Richard Biener via Gcc-patches wrote: > > On Sun, Jun 21, 2020 at 2:32 AM Yichao Yu via Gcc-patches > > wrote: > > > On Sat, Jun 20, 2020 at 8:16 PM Yichao Yu wrote: > > > > On Sat, Jun 20, 2020 at 3:41 PM Yic

Re: [PATCH] Fix target clone indirection elimination.

2020-06-26 Thread Jeff Law via Gcc-patches
On Mon, 2020-06-22 at 11:24 +0200, Richard Biener via Gcc-patches wrote: > On Sun, Jun 21, 2020 at 2:32 AM Yichao Yu via Gcc-patches > wrote: > > On Sat, Jun 20, 2020 at 8:16 PM Yichao Yu wrote: > > > On Sat, Jun 20, 2020 at 3:41 PM Yichao Yu wrote: > > > > On Sat, Jun 20, 2020 at 3:26 PM Yichao

Re: [PATCH] Fix target clone indirection elimination.

2020-06-22 Thread Richard Biener via Gcc-patches
On Sun, Jun 21, 2020 at 2:32 AM Yichao Yu via Gcc-patches wrote: > > On Sat, Jun 20, 2020 at 8:16 PM Yichao Yu wrote: > > > > On Sat, Jun 20, 2020 at 3:41 PM Yichao Yu wrote: > > > > > > On Sat, Jun 20, 2020 at 3:26 PM Yichao Yu wrote: > > > > > > > > On Sat, Jun 20, 2020 at 3:25 PM H.J. Lu wr

Re: [PATCH] Fix target clone indirection elimination (PR95778, PR95780)

2020-06-22 Thread Richard Biener via Gcc-patches
On Sat, Jun 20, 2020 at 6:17 PM Yichao Yu via Gcc-patches wrote: > > > The current logic seems to be comparing the whole attribute tree between the > callee > and caller (or at least the tree starting from the target attribute). > This is unnecessary and causes strange dependency of the indirecti

Re: [PATCH] Fix target clone indirection elimination.

2020-06-20 Thread Yichao Yu via Gcc-patches
On Sat, Jun 20, 2020 at 8:16 PM Yichao Yu wrote: > > On Sat, Jun 20, 2020 at 3:41 PM Yichao Yu wrote: > > > > On Sat, Jun 20, 2020 at 3:26 PM Yichao Yu wrote: > > > > > > On Sat, Jun 20, 2020 at 3:25 PM H.J. Lu wrote: > > > > > > > > On Sat, Jun 20, 2020 at 12:20 PM Yichao Yu wrote: > > > > >

Re: [PATCH] Fix target clone indirection elimination.

2020-06-20 Thread Yichao Yu via Gcc-patches
On Sat, Jun 20, 2020 at 3:41 PM Yichao Yu wrote: > > On Sat, Jun 20, 2020 at 3:26 PM Yichao Yu wrote: > > > > On Sat, Jun 20, 2020 at 3:25 PM H.J. Lu wrote: > > > > > > On Sat, Jun 20, 2020 at 12:20 PM Yichao Yu wrote: > > > > > > > > On Sat, Jun 20, 2020 at 3:12 PM H.J. Lu wrote: > > > > > >

Re: [PATCH] Fix target clone indirection elimination.

2020-06-20 Thread Yichao Yu via Gcc-patches
On Sat, Jun 20, 2020 at 3:26 PM Yichao Yu wrote: > > On Sat, Jun 20, 2020 at 3:25 PM H.J. Lu wrote: > > > > On Sat, Jun 20, 2020 at 12:20 PM Yichao Yu wrote: > > > > > > On Sat, Jun 20, 2020 at 3:12 PM H.J. Lu wrote: > > > > > > > > On Sat, Jun 20, 2020 at 11:37 AM Yichao Yu wrote: > > > > > >

Re: [PATCH] Fix target clone indirection elimination.

2020-06-20 Thread Yichao Yu via Gcc-patches
On Sat, Jun 20, 2020 at 3:25 PM H.J. Lu wrote: > > On Sat, Jun 20, 2020 at 12:20 PM Yichao Yu wrote: > > > > On Sat, Jun 20, 2020 at 3:12 PM H.J. Lu wrote: > > > > > > On Sat, Jun 20, 2020 at 11:37 AM Yichao Yu wrote: > > > > > > > > On Sat, Jun 20, 2020 at 1:54 PM Yichao Yu wrote: > > > > > >

Re: [PATCH] Fix target clone indirection elimination.

2020-06-20 Thread H.J. Lu via Gcc-patches
On Sat, Jun 20, 2020 at 12:20 PM Yichao Yu wrote: > > On Sat, Jun 20, 2020 at 3:12 PM H.J. Lu wrote: > > > > On Sat, Jun 20, 2020 at 11:37 AM Yichao Yu wrote: > > > > > > On Sat, Jun 20, 2020 at 1:54 PM Yichao Yu wrote: > > > > > > > > > > The current logic seems to be comparing the whole attri

Re: [PATCH] Fix target clone indirection elimination.

2020-06-20 Thread Yichao Yu via Gcc-patches
On Sat, Jun 20, 2020 at 3:12 PM H.J. Lu wrote: > > On Sat, Jun 20, 2020 at 11:37 AM Yichao Yu wrote: > > > > On Sat, Jun 20, 2020 at 1:54 PM Yichao Yu wrote: > > > > > > > > The current logic seems to be comparing the whole attribute tree > > > > > between the callee > > > > > and caller (or at

Re: [PATCH] Fix target clone indirection elimination.

2020-06-20 Thread H.J. Lu via Gcc-patches
On Sat, Jun 20, 2020 at 11:37 AM Yichao Yu wrote: > > On Sat, Jun 20, 2020 at 1:54 PM Yichao Yu wrote: > > > > > > The current logic seems to be comparing the whole attribute tree > > > > between the callee > > > > and caller (or at least the tree starting from the target attribute). > > > > Thi

Re: [PATCH] Fix target clone indirection elimination.

2020-06-20 Thread Yichao Yu via Gcc-patches
> https://github.com/gcc-mirror/gcc/commit/b8ce8129a560f64f8b2855c4a3812b7c3c0ebf3f#diff-e2d535917af8555baad2e9c8749e96a5 > with/adding to the test the following one should work. I still > couldn't get test to run though.. And yet another related issue that I think I would appreciate some help

Re: [PATCH] Fix target clone indirection elimination.

2020-06-20 Thread Yichao Yu via Gcc-patches
On Sat, Jun 20, 2020 at 1:54 PM Yichao Yu wrote: > > > > The current logic seems to be comparing the whole attribute tree between > > > the callee > > > and caller (or at least the tree starting from the target attribute). > > > This is unnecessary and causes strange dependency of the indirection

Re: [PATCH] Fix target clone indirection elimination.

2020-06-20 Thread Yichao Yu via Gcc-patches
> > The current logic seems to be comparing the whole attribute tree between > > the callee > > and caller (or at least the tree starting from the target attribute). > > This is unnecessary and causes strange dependency of the indirection > > elimination on unrelated properties like `noinline`(PR9

Re: [PATCH] Fix target clone indirection elimination.

2020-06-20 Thread H.J. Lu via Gcc-patches
On Sat, Jun 20, 2020 at 9:17 AM Yichao Yu via Gcc-patches wrote: > > The current logic seems to be comparing the whole attribute tree between the > callee > and caller (or at least the tree starting from the target attribute). > This is unnecessary and causes strange dependency of the indirection