Re: [PATCH] Fix store merging (PR tree-optimization/86844)

2018-09-12 Thread Richard Biener
On Wed, 12 Sep 2018, Jakub Jelinek wrote: > On Wed, Sep 12, 2018 at 11:04:52AM +0200, Richard Biener wrote: > > OK. We need to fix the bug on the branch, so either we go with this > > variant or the other (which was pessimizing some cases?) > > Yeah. Andreas' patch is simpler and for that reas

Re: [PATCH] Fix store merging (PR tree-optimization/86844)

2018-09-12 Thread Jakub Jelinek
On Wed, Sep 12, 2018 at 11:04:52AM +0200, Richard Biener wrote: > OK. We need to fix the bug on the branch, so either we go with this > variant or the other (which was pessimizing some cases?) Yeah. Andreas' patch is simpler and for that reason might be better to backport, on the other side try

Re: [PATCH] Fix store merging (PR tree-optimization/86844)

2018-09-12 Thread Richard Biener
On Wed, 12 Sep 2018, Jakub Jelinek wrote: > On Tue, Sep 11, 2018 at 04:06:40PM +0200, Andreas Krebbel wrote: > > > It is a fix, but not optimal. > > > We have essentially: > > > MEM[(int *)p_28] = 0; > > > MEM[(char *)p_28 + 3B] = 1; > > > MEM[(char *)p_28 + 1B] = 2; > > > MEM[