Re: [PATCH] Fix num_imm_uses (PR tree-optimization/70405)

2016-03-29 Thread Jakub Jelinek
On Wed, Mar 30, 2016 at 07:45:23AM +0200, Richard Biener wrote: > >Indeed, GCC 3.4 warns about this: > >pr70405-3.c:7: warning: suggest explicit braces to avoid ambiguous > >`else' > >That warning is still in there under -Wparentheses, but doesn't trigger > >anymore. > > Sounds like poor testsuite

Re: [PATCH] Fix num_imm_uses (PR tree-optimization/70405)

2016-03-29 Thread Richard Biener
On March 29, 2016 7:54:16 PM GMT+02:00, Jakub Jelinek wrote: >On Tue, Mar 29, 2016 at 07:46:32PM +0200, Bernd Schmidt wrote: >> On 03/29/2016 07:28 PM, Jeff Law wrote: >> >On 03/29/2016 11:23 AM, Jakub Jelinek wrote: >> >>Hi! >> >> >> >>The recent change to num_imm_uses (to add support for NULL >U

Re: [PATCH] Fix num_imm_uses (PR tree-optimization/70405)

2016-03-29 Thread Jakub Jelinek
On Tue, Mar 29, 2016 at 07:46:32PM +0200, Bernd Schmidt wrote: > On 03/29/2016 07:28 PM, Jeff Law wrote: > >On 03/29/2016 11:23 AM, Jakub Jelinek wrote: > >>Hi! > >> > >>The recent change to num_imm_uses (to add support for NULL USE_STMT) > >>broke it totally, fortunately we have just one user of t

Re: [PATCH] Fix num_imm_uses (PR tree-optimization/70405)

2016-03-29 Thread Bernd Schmidt
On 03/29/2016 07:28 PM, Jeff Law wrote: On 03/29/2016 11:23 AM, Jakub Jelinek wrote: Hi! The recent change to num_imm_uses (to add support for NULL USE_STMT) broke it totally, fortunately we have just one user of this function right now. I've filed a PR for GCC 7 so that we get a warning on th

Re: [PATCH] Fix num_imm_uses (PR tree-optimization/70405)

2016-03-29 Thread Jakub Jelinek
On Tue, Mar 29, 2016 at 11:28:20AM -0600, Jeff Law wrote: > On 03/29/2016 11:23 AM, Jakub Jelinek wrote: > >The recent change to num_imm_uses (to add support for NULL USE_STMT) > >broke it totally, fortunately we have just one user of this function > >right now. I've filed a PR for GCC 7 so that w

Re: [PATCH] Fix num_imm_uses (PR tree-optimization/70405)

2016-03-29 Thread Jeff Law
On 03/29/2016 11:23 AM, Jakub Jelinek wrote: Hi! The recent change to num_imm_uses (to add support for NULL USE_STMT) broke it totally, fortunately we have just one user of this function right now. I've filed a PR for GCC 7 so that we get a warning on this. Fixed thusly, bootstrapped/regtested