Re: [PATCH] Fix missing range information for "%q+D" format code

2015-12-07 Thread Bernd Schmidt
On 12/04/2015 10:09 PM, David Malcolm wrote: Updated patch to comment attached, which rewrites things to clarify the meaning of SHOW_CARET_P. I guess this is OK for now. I think I'll go play with the Fortran frontend a bit to see what exactly is going on with its use of set_range there, I sti

Re: [PATCH] Fix missing range information for "%q+D" format code

2015-12-04 Thread David Malcolm
On Fri, 2015-12-04 at 15:45 -0500, David Malcolm wrote: > On Fri, 2015-12-04 at 12:09 +0100, Bernd Schmidt wrote: > > On 12/03/2015 09:33 PM, David Malcolm wrote: > > > The attached patch updates the handling of %q+D, simplifying > > > the implementation, and ensuring that it retains the range > >

Re: [PATCH] Fix missing range information for "%q+D" format code

2015-12-04 Thread David Malcolm
On Fri, 2015-12-04 at 12:09 +0100, Bernd Schmidt wrote: > On 12/03/2015 09:33 PM, David Malcolm wrote: > > The attached patch updates the handling of %q+D, simplifying > > the implementation, and ensuring that it retains the range > > information of the decl, giving: > > > > diagnostic-ranges-1.c:6

Re: [PATCH] Fix missing range information for "%q+D" format code

2015-12-04 Thread Bernd Schmidt
On 12/03/2015 09:33 PM, David Malcolm wrote: The attached patch updates the handling of %q+D, simplifying the implementation, and ensuring that it retains the range information of the decl, giving: diagnostic-ranges-1.c:6:7: warning: unused variable ‘redundant’ [-Wunused-variable] int redun