Re: [PATCH] Fix gdb printers for std::string

2022-10-03 Thread Jonathan Wakely via Gcc-patches
On Mon, 3 Oct 2022 at 17:51, François Dumont wrote: > > On 01/10/22 17:30, Jonathan Wakely wrote: > > On Sat, 1 Oct 2022 at 11:43, François Dumont wrote: > >> On 01/10/22 12:06, Jonathan Wakely wrote: > >>> On Sat, 1 Oct 2022 at 08:20, François Dumont via Libstdc++ > >>> wrote: > I had forg

Re: [PATCH] Fix gdb printers for std::string

2022-10-03 Thread François Dumont via Gcc-patches
On 01/10/22 17:30, Jonathan Wakely wrote: On Sat, 1 Oct 2022 at 11:43, François Dumont wrote: On 01/10/22 12:06, Jonathan Wakely wrote: On Sat, 1 Oct 2022 at 08:20, François Dumont via Libstdc++ wrote: I had forgotten to re-run tests after I removed the #define _GLIBCXX_USE_CXX11_ABI 0. The

Re: [PATCH] Fix gdb printers for std::string

2022-10-01 Thread Jonathan Wakely via Gcc-patches
On Sat, 1 Oct 2022 at 11:43, François Dumont wrote: > > On 01/10/22 12:06, Jonathan Wakely wrote: > > On Sat, 1 Oct 2022 at 08:20, François Dumont via Libstdc++ > > wrote: > >> I had forgotten to re-run tests after I removed the #define > >> _GLIBCXX_USE_CXX11_ABI 0. > >> > >> The comment was mis

Re: [PATCH] Fix gdb printers for std::string

2022-10-01 Thread François Dumont via Gcc-patches
On 01/10/22 12:06, Jonathan Wakely wrote: On Sat, 1 Oct 2022 at 08:20, François Dumont via Libstdc++ wrote: I had forgotten to re-run tests after I removed the #define _GLIBCXX_USE_CXX11_ABI 0. The comment was misleading, it could also impact output of std::list. I am also restoring the corre

Re: [PATCH] Fix gdb printers for std::string

2022-10-01 Thread Jonathan Wakely via Gcc-patches
On Sat, 1 Oct 2022 at 08:20, François Dumont via Libstdc++ wrote: > > I had forgotten to re-run tests after I removed the #define > _GLIBCXX_USE_CXX11_ABI 0. > > The comment was misleading, it could also impact output of std::list. > > I am also restoring the correct std::string alias for > std::_

Re: [PATCH] Fix gdb printers for std::string

2022-10-01 Thread François Dumont via Gcc-patches
I had forgotten to re-run tests after I removed the #define _GLIBCXX_USE_CXX11_ABI 0. The comment was misleading, it could also impact output of std::list. I am also restoring the correct std::string alias for std::__cxx11::basic_string, even if with my workaround it doesn't really matter as