Re: [PATCH] Fix g++.dg/debug/dwarf2/thunk1.C on darwin

2013-03-06 Thread Jason Merrill
Whoops, I thought I had run that test to make sure the syntax was right, but apparently I ran a different thunk1.C instead. Fixed now. Jason

Re: [PATCH] Fix g++.dg/debug/dwarf2/thunk1.C on darwin

2013-03-06 Thread Rainer Orth
domi...@lps.ens.fr (Dominique Dhumieres) writes: > The test fails with > > ERROR: g++.dg/debug/dwarf2/thunk1.C -std=gnu++98: dg-skip-if 2: need 2, 3, > or 4 arguments for " dg-skip-if 7 { target *-*-darwin* } " > > From the test suite the syntax should be of the kind > > /* { dg-skip-if "no alignm

Re: [PATCH] Fix g++.dg/debug/dwarf2/thunk1.C on darwin

2013-03-06 Thread Dominique Dhumieres
Jason, The test fails with ERROR: g++.dg/debug/dwarf2/thunk1.C -std=gnu++98: dg-skip-if 2: need 2, 3, or 4 arguments for " dg-skip-if 7 { target *-*-darwin* } " >From the test suite the syntax should be of the kind /* { dg-skip-if "no alignment constraints" { "avr-*-*" } { "*" } { "" } } */ T

Re: [PATCH] Fix g++.dg/debug/dwarf2/thunk1.C on darwin

2013-03-06 Thread Jason Merrill
On 03/06/2013 06:33 AM, Rainer Orth wrote: Why not skip the whole test with dg-skip-if, since the scan is the whole point of the testcase AFAICT? Also, please add a comment explaining why the test is skipped, perhaps referencing the PR. Here's what I'm checking in: commit cd378936f38da43429

Re: [PATCH] Fix g++.dg/debug/dwarf2/thunk1.C on darwin

2013-03-06 Thread Rainer Orth
Jack Howarth writes: > 2013-03-05 Jack Howarth > > PR debug/53363 > * g++.dg/debug/dwarf2/thunk1.C: Skip final scan on darwin. > > Index: gcc/testsuite/g++.dg/debug/dwarf2/thunk1.C > === > --- gcc/testsuite/g++.dg/debu