Re: [PATCH] Fix for PR 61561

2014-07-11 Thread Richard Earnshaw
On 19/06/14 21:19, Yuri Gribov wrote: >> Thirdly, we also need to fix movhi_bytes (for pre-v4) thumb2_movhi_insn >> (for thumb2) and, quite possibly, thumb1_movhi_insn (for thumb1). There >> may well be additional changes for movqi variants as well. > > A general question: how should one test ARM

Re: [PATCH] Fix for PR 61561

2014-07-10 Thread Ramana Radhakrishnan
On Thu, Jun 19, 2014 at 9:19 PM, Yuri Gribov wrote: >> Thirdly, we also need to fix movhi_bytes (for pre-v4) thumb2_movhi_insn >> (for thumb2) and, quite possibly, thumb1_movhi_insn (for thumb1). There >> may well be additional changes for movqi variants as well. > > A general question: how shoul

Re: [PATCH] Fix for PR 61561

2014-06-19 Thread Yuri Gribov
> Thirdly, we also need to fix movhi_bytes (for pre-v4) thumb2_movhi_insn > (for thumb2) and, quite possibly, thumb1_movhi_insn (for thumb1). There > may well be additional changes for movqi variants as well. A general question: how should one test ARM backend patches? Is it enough to regtest ARM

Re: [PATCH] Fix for PR 61561

2014-06-19 Thread Ramana Radhakrishnan
On 19/06/14 16:12, Kyrill Tkachov wrote: On 19/06/14 16:05, Marat Zakirov wrote: Hi all, Here's a patch for PR 61561 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61561). It fixes ICE. Thanks for your contribution. However, this is *really* not the way to submit a patch and is the sort

Re: [PATCH] Fix for PR 61561

2014-06-19 Thread Richard Earnshaw
On 19/06/14 16:05, Marat Zakirov wrote: > Hi all, > > Here's a patch for PR 61561 > (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61561). > > It fixes ICE. > > Reg. tested on arm15. > > --Marat > > > arm.md.diff.diff > > > gcc/ChangeLog: > > 2014-06-19 Marat Zakirov > > * config

Re: [PATCH] Fix for PR 61561

2014-06-19 Thread Yuri Gribov
> + (if_then_else (match_operand 1 "const_int_operand" > "") > +(const_string "mov_imm" ) > +(const_string "mov_reg"))])] Why not just mov_reg? > * config/arm/arm.md: New templates see pr6156

Re: [PATCH] Fix for PR 61561

2014-06-19 Thread Kyrill Tkachov
On 19/06/14 16:05, Marat Zakirov wrote: Hi all, Here's a patch for PR 61561 (https://gcc.gnu.org/bugzilla/show_bug.cgi?id=61561). It fixes ICE. Reg. tested on arm15. CC'ing the arm maintainers... Kyrill --Marat