Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Jason Merrill
On 02/04/2016 12:24 PM, Patrick Palka wrote: On Thu, Feb 4, 2016 at 11:57 AM, Jason Merrill wrote: On 02/04/2016 10:32 AM, Patrick Palka wrote: On Thu, Feb 4, 2016 at 9:24 AM, Jason Merrill wrote: On 02/03/2016 12:51 PM, Patrick Palka wrote: + && (integer_minus_onep (lhs) +

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Patrick Palka
On Thu, Feb 4, 2016 at 12:24 PM, Patrick Palka wrote: > On Thu, Feb 4, 2016 at 11:57 AM, Jason Merrill wrote: >> On 02/04/2016 10:32 AM, Patrick Palka wrote: >>> >>> On Thu, Feb 4, 2016 at 9:24 AM, Jason Merrill wrote: On 02/03/2016 12:51 PM, Patrick Palka wrote: > > > +

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Patrick Palka
On Thu, Feb 4, 2016 at 11:57 AM, Jason Merrill wrote: > On 02/04/2016 10:32 AM, Patrick Palka wrote: >> >> On Thu, Feb 4, 2016 at 9:24 AM, Jason Merrill wrote: >>> >>> On 02/03/2016 12:51 PM, Patrick Palka wrote: + && (integer_minus_onep (lhs) + || integer_

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Jason Merrill
On 02/04/2016 10:32 AM, Patrick Palka wrote: On Thu, Feb 4, 2016 at 9:24 AM, Jason Merrill wrote: On 02/03/2016 12:51 PM, Patrick Palka wrote: + && (integer_minus_onep (lhs) + || integer_minus_onep (rhs))) Let's use null_member_pointer_value_p here. Done. Please ad

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Patrick Palka
On Thu, Feb 4, 2016 at 9:24 AM, Jason Merrill wrote: > On 02/03/2016 12:51 PM, Patrick Palka wrote: >> >> + && (integer_minus_onep (lhs) >> + || integer_minus_onep (rhs))) > > > Let's use null_member_pointer_value_p here. Done. > > Please add pointers to member functions to t

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-04 Thread Jason Merrill
On 02/03/2016 12:51 PM, Patrick Palka wrote: + && (integer_minus_onep (lhs) + || integer_minus_onep (rhs))) Let's use null_member_pointer_value_p here. Please add pointers to member functions to the testcase. Jason

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-03 Thread Patrick Palka
On Tue, 2 Feb 2016, Jason Merrill wrote: On 12/22/2015 12:07 AM, Patrick Palka wrote: + if (code == EQ_EXPR || code == NE_EXPR) +{ + if (TREE_CODE (lhs) == PTRMEM_CST && CONSTANT_CLASS_P (rhs)) + lhs = cplus_expand_constant (lhs); + if (TREE_CODE (rhs) == PTRMEM_CST && CONS

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-02-03 Thread Jason Merrill
On 12/22/2015 12:07 AM, Patrick Palka wrote: + if (code == EQ_EXPR || code == NE_EXPR) +{ + if (TREE_CODE (lhs) == PTRMEM_CST && CONSTANT_CLASS_P (rhs)) + lhs = cplus_expand_constant (lhs); + if (TREE_CODE (rhs) == PTRMEM_CST && CONSTANT_CLASS_P (lhs)) + rhs = cplus_exp

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-01-24 Thread Patrick Palka
On Sun, Jan 10, 2016 at 10:19 PM, Patrick Palka wrote: > On Mon, Dec 21, 2015 at 6:07 PM, Patrick Palka wrote: >> We are currently failing to fold equality comparisons involving >> PTRMEM_CSTs since (I think) r229018 thus making this a GCC 6 regression. >> This regression shows up in the boost te

Re: [PATCH] Fix constexpr evaluation of comparisons involving pointer-to-members

2016-01-10 Thread Patrick Palka
On Mon, Dec 21, 2015 at 6:07 PM, Patrick Palka wrote: > We are currently failing to fold equality comparisons involving > PTRMEM_CSTs since (I think) r229018 thus making this a GCC 6 regression. > This regression shows up in the boost testsuite. > > Fixed in a straightforward way. OK to commit af