Hi Richard:
> I do think that local variable layout probably doesn't belong in that IPA pass
> but elsewhere (way earlier). But my main complaint was that the diff
> doesn't show changes you made to the pass because it first and foremost
> shows moving all the code. That makes reviewing the chan
On Fri, Mar 27, 2020 at 2:54 PM Richard Biener
wrote:
>
> On Fri, Mar 27, 2020 at 2:04 PM Kito Cheng wrote:
> >
> > Hi Richard:
> >
> > The local variable alignment adjustment was removed at this commit:
> > https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=26d7a5e690169ac04acde90070b0092c41b71c7e
On Fri, Mar 27, 2020 at 2:04 PM Kito Cheng wrote:
>
> Hi Richard:
>
> The local variable alignment adjustment was removed at this commit:
> https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=26d7a5e690169ac04acde90070b0092c41b71c7e
>
> And it's a little bit indirectly, it called from
> estimate_stack_
Hi Richard:
The local variable alignment adjustment was removed at this commit:
https://gcc.gnu.org/git/gitweb.cgi?p=gcc.git;h=26d7a5e690169ac04acde90070b0092c41b71c7e
And it's a little bit indirectly, it called from
estimate_stack_frame_size, call stack like:
estimate_stack_frame_size -> expand_
On Fri, Mar 27, 2020 at 1:28 PM Kito Cheng wrote:
>
> - The alignment for local variable was adjust during
> estimate_stack_frame_size,
>however it seems wrong spot to adjust that.
>
> - So we must adjust at some point, and here is already a pass to adjust
>alignment, which is ipa-incre
