Re: [PATCH] Fix a few of the PVS studio reported bugs

2020-04-17 Thread Richard Biener
On Fri, 17 Apr 2020, Jakub Jelinek wrote: > On Fri, Apr 17, 2020 at 09:39:20AM +0200, Richard Biener wrote: > > On Fri, 17 Apr 2020, Jakub Jelinek wrote: > > > > > On Fri, Apr 17, 2020 at 09:24:34AM +0200, Richard Biener wrote: > > > > --- a/gcc/optabs.c > > > > +++ b/gcc/optabs.c > > > > @@ -105

Re: [PATCH] Fix a few of the PVS studio reported bugs

2020-04-17 Thread Jakub Jelinek via Gcc-patches
On Fri, Apr 17, 2020 at 09:39:20AM +0200, Richard Biener wrote: > On Fri, 17 Apr 2020, Jakub Jelinek wrote: > > > On Fri, Apr 17, 2020 at 09:24:34AM +0200, Richard Biener wrote: > > > --- a/gcc/optabs.c > > > +++ b/gcc/optabs.c > > > @@ -1050,7 +1050,7 @@ expand_binop_directly (enum insn_code icod

Re: [PATCH] Fix a few of the PVS studio reported bugs

2020-04-17 Thread Richard Biener
On Fri, 17 Apr 2020, Jakub Jelinek wrote: > On Fri, Apr 17, 2020 at 09:24:34AM +0200, Richard Biener wrote: > > --- a/gcc/optabs.c > > +++ b/gcc/optabs.c > > @@ -1050,7 +1050,7 @@ expand_binop_directly (enum insn_code icode, > > machine_mode mode, optab binoptab, > >commutative_p = commutativ

Re: [PATCH] Fix a few of the PVS studio reported bugs

2020-04-17 Thread Jakub Jelinek via Gcc-patches
On Fri, Apr 17, 2020 at 09:24:34AM +0200, Richard Biener wrote: > --- a/gcc/optabs.c > +++ b/gcc/optabs.c > @@ -1050,7 +1050,7 @@ expand_binop_directly (enum insn_code icode, > machine_mode mode, optab binoptab, >commutative_p = commutative_optab_p (binoptab); >if (commutative_p >&