On Mon, 4 Mar 2013, Joey Ye wrote:
> + char *new_spec = (char *)xmalloc (len + number_of_space + 1);
Space in cast between "(char *)" and "xmalloc". OK with that change.
--
Joseph S. Myers
jos...@codesourcery.com
> -Original Message-
> From: Georg-Johann Lay [mailto:g...@gcc.gnu.org]
> Sent: Monday, March 04, 2013 02:42
> To: Joey Ye
> Cc: 'Joseph Myers'; gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] Fix PR50293 - LTO plugin with space in path
>
> Joey Ye schr
> -Original Message-
> From: Joseph Myers [mailto:jos...@codesourcery.com]
> Sent: Monday, March 04, 2013 00:49
> To: Joey Ye
> Cc: gcc-patches@gcc.gnu.org
> Subject: RE: [PATCH] Fix PR50293 - LTO plugin with space in path
>
> On Mon, 18 Feb 2013, Joey Ye wr
Joey Ye schrieb:
Ping
Subject: RE: [PATCH] Fix PR50293 - LTO plugin with space in path
Does this patch also work with MS-Windows as host, i.e. with \ as path
separator?
+static char * convert_white_space(char * orig);
Please fix formatting in many places in this patch to follow the GNU
On Mon, 18 Feb 2013, Joey Ye wrote:
> +static char * convert_white_space (char *);
No space after "*".
> - linker_plugin_file_spec = find_a_file (&exec_prefixes,
> + char * temp_spec = find_a_file (&exec_prefixes,
>LTOPLUGIN
Ping
> -Original Message-
> From: Joey Ye [mailto:joey...@arm.com]
> Sent: Monday, February 18, 2013 11:32
> To: 'Joseph Myers'
> Cc: gcc-patches@gcc.gnu.org
> Subject: RE: [PATCH] Fix PR50293 - LTO plugin with space in path
>
> Joseph, Thanks for your v
Joseph, Thanks for your valuable comments. See my reply and new patch below.
> -Original Message-
> From: Joseph Myers [mailto:jos...@codesourcery.com]
> Sent: Monday, February 18, 2013 06:16
> To: Joey Ye
> Cc: gcc-patches@gcc.gnu.org
> Subject: Re: [PATCH] Fix PR50293
On Sun, 17 Feb 2013, Joey Ye wrote:
> +static char * convert_white_space(char * orig);
Please fix formatting in many places in this patch to follow the GNU
Coding Standards. No space after '*', but space before '('; there seem to
be various other formatting problems as well.
> +/* Insert back
