Re: [PATCH] Fix PR47691: always run scev_const_prop before graphite

2011-07-27 Thread Richard Guenther
On Tue, 26 Jul 2011, Sebastian Pop wrote: > On Tue, Jul 26, 2011 at 10:56, Sebastian Pop wrote: > > On Tue, Jul 26, 2011 at 10:43, Richard Guenther wrote: > >> Please make graphite more robust instead. > > > > Ok, in this case, what about setting gloog_error and stopping the code > > generation

Re: [PATCH] Fix PR47691: always run scev_const_prop before graphite

2011-07-26 Thread Sebastian Pop
On Tue, Jul 26, 2011 at 10:56, Sebastian Pop wrote: > On Tue, Jul 26, 2011 at 10:43, Richard Guenther wrote: >> Please make graphite more robust instead. > > Ok, in this case, what about setting gloog_error and stopping the code > generation instead of failing on this gcc_assert. > Here is the p

Re: [PATCH] Fix PR47691: always run scev_const_prop before graphite

2011-07-26 Thread Sebastian Pop
On Tue, Jul 26, 2011 at 10:43, Richard Guenther wrote: > Required?  Do you mean you generate wrong code in graphite if it is > not run? Graphite won't generate wrong code if scev_cprop is not run: it will fail on an assert in the code generation part. We used to know the scev for the induction v

Re: [PATCH] Fix PR47691: always run scev_const_prop before graphite

2011-07-26 Thread Richard Guenther
On Tue, 26 Jul 2011, Sebastian Pop wrote: > On Tue, Jul 26, 2011 at 09:33, Richard Guenther wrote: > > On Tue, 26 Jul 2011, Sebastian Pop wrote: > > > >> Ping. > >> Any opinions on this patch? > > > > Well, I don't think we should do this.  Why does the user disable > > scev-const-prop when enabl

Re: [PATCH] Fix PR47691: always run scev_const_prop before graphite

2011-07-26 Thread Sebastian Pop
On Tue, Jul 26, 2011 at 09:33, Richard Guenther wrote: > On Tue, 26 Jul 2011, Sebastian Pop wrote: > >> Ping. >> Any opinions on this patch? > > Well, I don't think we should do this.  Why does the user disable > scev-const-prop when enabling graphite?  If he does so, fine - he > has to live with

Re: [PATCH] Fix PR47691: always run scev_const_prop before graphite

2011-07-26 Thread Richard Guenther
On Tue, 26 Jul 2011, Sebastian Pop wrote: > Ping. > Any opinions on this patch? Well, I don't think we should do this. Why does the user disable scev-const-prop when enabling graphite? If he does so, fine - he has to live with worse codegen. Richard. > Thanks, > Sebastian > > On Sat, Jul 23,

Re: [PATCH] Fix PR47691: always run scev_const_prop before graphite

2011-07-26 Thread Sebastian Pop
Ping. Any opinions on this patch? Thanks, Sebastian On Sat, Jul 23, 2011 at 23:40, Sebastian Pop wrote: > This patch makes graphite run the scev_const_prop systematically even > when using -fno-tree-scev-cprop.  When scev_const_prop is not applied, > there exist close_phi nodes for the main indu