Re: [PATCH] Fix PR33763

2012-01-24 Thread Joseph S. Myers
On Mon, 16 Jan 2012, Richard Guenther wrote: > + /* Do not merge an extern inline decl with any other decl either. */ > + if ((DECL_DECLARED_INLINE_P (newdecl) > +&& DECL_EXTERNAL (newdecl)) > + || (!flag_gnu89_inline > + && (DECL_DECLARED_INLINE_P (newdecl) >

Re: [PATCH] Fix PR33763

2012-01-16 Thread Richard Guenther
On Mon, 16 Jan 2012, Richard Guenther wrote: > On Mon, 16 Jan 2012, Jakub Jelinek wrote: > > > On Mon, Jan 16, 2012 at 09:35:08AM +0100, Richard Guenther wrote: > > > But that's of course intended. Attributes or redirection on the > > > extern inline variant are completely meaningless. > > > >

Re: [PATCH] Fix PR33763

2012-01-16 Thread Richard Guenther
On Mon, 16 Jan 2012, Jakub Jelinek wrote: > On Mon, Jan 16, 2012 at 09:35:08AM +0100, Richard Guenther wrote: > > But that's of course intended. Attributes or redirection on the > > extern inline variant are completely meaningless. > > > > > If you want to keep olddecl as is, then IMHO we should

Re: [PATCH] Fix PR33763

2012-01-16 Thread Jakub Jelinek
On Mon, Jan 16, 2012 at 09:35:08AM +0100, Richard Guenther wrote: > But that's of course intended. Attributes or redirection on the > extern inline variant are completely meaningless. > > > If you want to keep olddecl as is, then IMHO we should add a new bool > > argument to merge_decls and if th

Re: [PATCH] Fix PR33763

2012-01-16 Thread Richard Guenther
On Fri, 13 Jan 2012, Jakub Jelinek wrote: > On Fri, Jan 13, 2012 at 11:05:36AM +0100, Richard Guenther wrote: > > This fixes the ICEs that occur with redeclared extern inline functions > > in some circumstances. It avoids the cgraph confusion by _not_ merging > > the two decls in this case but si

Re: [PATCH] Fix PR33763

2012-01-13 Thread Jakub Jelinek
On Fri, Jan 13, 2012 at 11:05:36AM +0100, Richard Guenther wrote: > This fixes the ICEs that occur with redeclared extern inline functions > in some circumstances. It avoids the cgraph confusion by _not_ merging > the two decls in this case but simply drops the old (extern inline) > one on the flo

Re: [PATCH] Fix PR33763

2012-01-13 Thread Richard Guenther
On Fri, 13 Jan 2012, Richard Guenther wrote: > > This fixes the ICEs that occur with redeclared extern inline functions > in some circumstances. It avoids the cgraph confusion by _not_ merging > the two decls in this case but simply drops the old (extern inline) > one on the floor. This causes