Re: [PATCH] Fix PR ipa/65908.

2015-06-21 Thread Jan Hubicka
Hi, this patch extends earlier Martin's patch. I completely removed parse_tree_args because it assumed that every function has only one set of parm types and one return value type. We really want to compare two sets of parameter types (DECL_ARGUMENTS and TYPE_PARM_TYPES) as they do not need to 100

Re: [PATCH] Fix PR ipa/65908.

2015-06-17 Thread Martin Liška
On 06/10/2015 01:50 PM, Martin Liška wrote: > On 05/15/2015 08:52 PM, Jan Hubicka wrote: >>> +/* Return true if DECL_ARGUMENT types are valid to be merged. */ >> Perhaps bettter as >> >> Perform additional check needed to match types function parameters that are >> used. Unlike for normal paramet

Re: [PATCH] Fix PR ipa/65908.

2015-06-10 Thread Martin Liška
On 05/15/2015 08:52 PM, Jan Hubicka wrote: >> +/* Return true if DECL_ARGUMENT types are valid to be merged. */ > Perhaps bettter as > > Perform additional check needed to match types function parameters that are > used. Unlike for normal parameters it matters if type is TYPE_RESTRICT and we > m

Re: [PATCH] Fix PR ipa/65908.

2015-05-15 Thread Jan Hubicka
> +/* Return true if DECL_ARGUMENT types are valid to be merged. */ Perhaps bettter as Perform additional check needed to match types function parameters that are used. Unlike for normal parameters it matters if type is TYPE_RESTRICT and we make an assumption that REFERENCE_TYPE parameters are a

Re: [PATCH] Fix PR ipa/65908.

2015-05-15 Thread Martin Liška
On 05/15/2015 12:38 PM, Jakub Jelinek wrote: On Fri, May 15, 2015 at 10:38:57AM +0200, Martin Liška wrote: Following patch is fix for GCC-5 branch for PR ipa/65908, was tested on x86_64-linux-pc, as well as bootstrapped. As soon as the patch is applied, I'm going to send the similar patch for t

Re: [PATCH] Fix PR ipa/65908.

2015-05-15 Thread Jakub Jelinek
On Fri, May 15, 2015 at 10:38:57AM +0200, Martin Liška wrote: > Following patch is fix for GCC-5 branch for PR ipa/65908, was tested on > x86_64-linux-pc, as well as bootstrapped. > As soon as the patch is applied, I'm going to send the similar patch for > trunk. I'll leave the review to Honza o