Re: [PATCH] Fix PR 93242: patchable-function-entry broken on MIPS

2020-01-22 Thread Jeff Law
On Wed, 2020-01-22 at 13:16 -0800, Andrew Pinski wrote: > On Wed, Jan 22, 2020 at 12:48 PM Jeff Law wrote: > > On Mon, 2020-01-20 at 09:42 +0100, Richard Biener wrote: > > > On Sat, Jan 18, 2020 at 1:47 AM wrote: > > > > From: Andrew Pinski > > > > > > > > On MIPS, .set noreorder/reorder needs

Re: [PATCH] Fix PR 93242: patchable-function-entry broken on MIPS

2020-01-22 Thread Andrew Pinski
On Wed, Jan 22, 2020 at 1:16 PM Andrew Pinski wrote: > > On Wed, Jan 22, 2020 at 12:48 PM Jeff Law wrote: > > > > On Mon, 2020-01-20 at 09:42 +0100, Richard Biener wrote: > > > On Sat, Jan 18, 2020 at 1:47 AM wrote: > > > > From: Andrew Pinski > > > > > > > > On MIPS, .set noreorder/reorder nee

Re: [PATCH] Fix PR 93242: patchable-function-entry broken on MIPS

2020-01-22 Thread Andrew Pinski
On Wed, Jan 22, 2020 at 12:48 PM Jeff Law wrote: > > On Mon, 2020-01-20 at 09:42 +0100, Richard Biener wrote: > > On Sat, Jan 18, 2020 at 1:47 AM wrote: > > > From: Andrew Pinski > > > > > > On MIPS, .set noreorder/reorder needs to emitted around > > > the nop. The template for the nop instruct

Re: [PATCH] Fix PR 93242: patchable-function-entry broken on MIPS

2020-01-22 Thread Jeff Law
On Mon, 2020-01-20 at 09:42 +0100, Richard Biener wrote: > On Sat, Jan 18, 2020 at 1:47 AM wrote: > > From: Andrew Pinski > > > > On MIPS, .set noreorder/reorder needs to emitted around > > the nop. The template for the nop instruction uses %(/%) to > > do that. But default_print_patchable_fun

Re: [PATCH] Fix PR 93242: patchable-function-entry broken on MIPS

2020-01-20 Thread Richard Biener
On Sat, Jan 18, 2020 at 1:47 AM wrote: > > From: Andrew Pinski > > On MIPS, .set noreorder/reorder needs to emitted around > the nop. The template for the nop instruction uses %(/%) to > do that. But default_print_patchable_function_entry uses > fprintf rather than output_asm_insn to output the