Re: [PATCH] Fix --help -Q output

2021-12-07 Thread Richard Biener via Gcc-patches
On Thu, Dec 2, 2021 at 4:55 PM Martin Liška wrote: > > On 12/2/21 15:22, Martin Liška wrote: > > On 12/2/21 15:11, Richard Biener wrote: > >> the ?:s look odd to me, the above is equivalent to v > 0 ? 1 : 0, no? > >> Did you mean to make v > 0 v != 0? > > > > Yeah, it's typo, should be 'v != 0 ?

Re: [PATCH] Fix --help -Q output

2021-12-02 Thread Martin Liška
On 12/2/21 15:22, Martin Liška wrote: On 12/2/21 15:11, Richard Biener wrote: the ?:s look odd to me, the above is equivalent to v >  0 ? 1 : 0, no? Did you mean to make v > 0 v != 0? Yeah, it's typo, should be 'v != 0 ? ...'. Martin There's a tested patch can bootstrap on x86_64-linux-gnu

Re: [PATCH] Fix --help -Q output

2021-12-02 Thread Martin Liška
On 12/2/21 15:11, Richard Biener wrote: the ?:s look odd to me, the above is equivalent to v > 0 ? 1 : 0, no? Did you mean to make v > 0 v != 0? Yeah, it's typo, should be 'v != 0 ? ...'. Martin

Re: [PATCH] Fix --help -Q output

2021-12-02 Thread Richard Biener via Gcc-patches
On Thu, Dec 2, 2021 at 3:07 PM Martin Liška wrote: > > On 11/30/21 10:33, Richard Biener wrote: > > and the "docs" say > > > >/* The switch is enabled when FLAG_VAR is nonzero. */ > >CLVC_BOOLEAN, > > That's bogus, because real meaning of CLVC_BOOLEAN is that it holds an > integer value.

Re: [PATCH] Fix --help -Q output

2021-12-02 Thread Martin Liška
On 11/30/21 10:33, Richard Biener wrote: and the "docs" say /* The switch is enabled when FLAG_VAR is nonzero. */ CLVC_BOOLEAN, That's bogus, because real meaning of CLVC_BOOLEAN is that it holds an integer value. It can be just true/false for a simple flag, can be 0,1,2 for things lik

Re: [PATCH] Fix --help -Q output

2021-11-30 Thread Richard Biener via Gcc-patches
On Mon, Nov 29, 2021 at 4:16 PM Martin Liška wrote: > > There are cases where a default option value is -1 and > auto-detection happens in e.g. target. > > Do not print these options. Leads to the following diff: > > - -fdelete-null-pointer-checks [enabled] > + -fdelete-null-poin