Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-18 Thread Martin Liška
On 2/18/20 11:09 AM, Richard Biener wrote: On Mon, Feb 17, 2020 at 3:47 PM Martin Liška wrote: Sorry, I attached wrong patch. Ah yeah, that looks like a better place (the IPA pure-const one). OK with Jakubs suggested changes. Richard. Martin All right. There's hopefully a final version

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-18 Thread Richard Biener
On Mon, Feb 17, 2020 at 3:48 PM Jakub Jelinek wrote: > > On Mon, Feb 17, 2020 at 03:44:53PM +0100, Martin Liška wrote: > > + error ("MALLOC attribute set on a void function"); > > Why the capitals? Either malloc or % IMSHO. > What is special about void functions, missing lhs? That can be mi

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-18 Thread Richard Biener
On Mon, Feb 17, 2020 at 3:47 PM Martin Liška wrote: > > Sorry, I attached wrong patch. Ah yeah, that looks like a better place (the IPA pure-const one). OK with Jakubs suggested changes. Richard. > Martin

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-17 Thread Martin Liška
On 2/17/20 3:48 PM, Jakub Jelinek wrote: On Mon, Feb 17, 2020 at 03:44:53PM +0100, Martin Liška wrote: + error ("MALLOC attribute set on a void function"); Why the capitals? Either malloc or % IMSHO. Sure, I'll fix it. What is special about void functions, missing lhs? That can be m

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-17 Thread Jakub Jelinek
On Mon, Feb 17, 2020 at 03:44:53PM +0100, Martin Liška wrote: > + error ("MALLOC attribute set on a void function"); Why the capitals? Either malloc or % IMSHO. What is special about void functions, missing lhs? That can be missing for other functions (where you just don't use the return va

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-17 Thread Martin Jambor
Hi, On Mon, Feb 17 2020, Richard Biener wrote: > On Mon, Feb 17, 2020 at 1:16 PM Martin Liška wrote: >> >> Hello. >> >> As mentioned in the PR, we end up with a void function >> call that has set MALLOC attribute. That causes problems in RTL >> expansion. >> >> I believe a proper fix is to drop t

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-17 Thread Martin Liška
Sorry, I attached wrong patch. Martin >From c215a4d5d5d5aa72729c16408805eb9ddf5f0d38 Mon Sep 17 00:00:00 2001 From: Martin Liska Date: Mon, 17 Feb 2020 12:33:28 +0100 Subject: [PATCH] Drop MALLOC attribute for void functions. gcc/ChangeLog: 2020-02-17 Martin Liska PR ipa/93583 * cgraph.c

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-17 Thread Martin Liška
On 2/17/20 3:25 PM, Richard Biener wrote: On Mon, Feb 17, 2020 at 1:16 PM Martin Liška wrote: Hello. As mentioned in the PR, we end up with a void function call that has set MALLOC attribute. That causes problems in RTL expansion. I believe a proper fix is to drop the attribute when a callgr

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-17 Thread Richard Biener
On Mon, Feb 17, 2020 at 1:16 PM Martin Liška wrote: > > Hello. > > As mentioned in the PR, we end up with a void function > call that has set MALLOC attribute. That causes problems in RTL > expansion. > > I believe a proper fix is to drop the attribute when a callgraph > clone with void type is cr

Re: [PATCH] Drop MALLOC attribute for void functions.

2020-02-17 Thread Martin Jambor
Hi, On Mon, Feb 17 2020, Martin Liška wrote: > Hello. > > As mentioned in the PR, we end up with a void function > call that has set MALLOC attribute. That causes problems in RTL > expansion. > > I believe a proper fix is to drop the attribute when a callgraph > clone with void type is created. >