Re: [PATCH] Don't override user alignment with the same value

2017-08-21 Thread Eric Botcazou
> According to Eric: > > https://gcc.gnu.org/bugzilla/show_bug.cgi?id=53037#c32 > > "if (mode_align >= TYPE_ALIGN (type))" was intentional. I am > not familiar with STRICT_ALIGNMENT target and there is no > testcase to show why it is needed. Yes, the mode promotion triggers the alignment promot

Re: [PATCH] Don't override user alignment with the same value

2017-08-21 Thread H.J. Lu
On Mon, Aug 21, 2017 at 12:59 AM, Richard Biener wrote: > On Sat, Aug 19, 2017 at 10:18 PM, H.J. Lu wrote: >> Don't override alignment specified by user with the same value to >> preserve TYPE_USER_ALIGN. This fixes PR 53037 tests on Sparc. >> >> Does it look right? > > Doesn't match do_type_ali

Re: [PATCH] Don't override user alignment with the same value

2017-08-21 Thread Richard Biener
On Sat, Aug 19, 2017 at 10:18 PM, H.J. Lu wrote: > Don't override alignment specified by user with the same value to > preserve TYPE_USER_ALIGN. This fixes PR 53037 tests on Sparc. > > Does it look right? Doesn't match do_type_align so it introduces inconsistencies. The documentation for TYPE_U