Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Tue, 2014-06-03 at 15:21 +0200, Jakub Jelinek wrote: > On Tue, Jun 03, 2014 at 08:06:41AM -0500, Peter Bergner wrote: > > No LD_PRELOAD. It adds -lasan "early", but after the libraries and > > object files that are explicitly added to the linker command. > > Since -lm is explicitly added to the

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Tue, Jun 03, 2014 at 08:06:41AM -0500, Peter Bergner wrote: > On Tue, 2014-06-03 at 08:41 +0200, Jakub Jelinek wrote: > > On Tue, Jun 03, 2014 at 10:19:48AM +0400, Yury Gribov wrote: > > > >I took that patch and applied it to the gcc sources, > > > >but I still see the error on ppc: > > > >... >

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

> It adds -lasan "early", but after the libraries and > object files that are explicitly added to the linker command. > Since -lm is explicitly added to the linker command, the implicitly > added -lasan comes after. The -v command is below. Hm, -lasan manages to override user-specified -lm on gc

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Tue, 2014-06-03 at 08:41 +0200, Jakub Jelinek wrote: > On Tue, Jun 03, 2014 at 10:19:48AM +0400, Yury Gribov wrote: > > >I took that patch and applied it to the gcc sources, > > >but I still see the error on ppc: > > >... > > >[bergner@makalu-lp1 asan]$ > > >LD_LIBRARY_PATH=:/home/bergner/gcc/b

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Tue, Jun 03, 2014 at 10:19:48AM +0400, Yury Gribov wrote: > >I took that patch and applied it to the gcc sources, > >but I still see the error on ppc: > >... > >[bergner@makalu-lp1 asan]$ > >LD_LIBRARY_PATH=:/home/bergner/gcc/build/gcc-fsf-mainline-asan-debug-3/gcc:/home/bergner/gcc/build/gcc-f

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

I took that patch and applied it to the gcc sources, but I still see the error on ppc: ... [bergner@makalu-lp1 asan]$ LD_LIBRARY_PATH=:/home/bergner/gcc/build/gcc-fsf-mainline-asan-debug-3/gcc:/home/bergner/gcc/build/gcc-fsf-mainline-asan-debug-3/gcc/32:/home/bergner/gcc/build/gcc-fsf-mainline-as

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Mon, 2014-06-02 at 14:48 +0400, Konstantin Serebryany wrote: > Committed as r210012, please don't forget to add llvm-commits to CC > next time (I did not see the message) > Thanks! I took that patch and applied it to the gcc sources, but I still see the error on ppc: [bergner@makalu-lp1 asan]$

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

Committed as r210012, please don't forget to add llvm-commits to CC next time (I did not see the message) Thanks! On Mon, Jun 2, 2014 at 9:57 AM, Yury Gribov wrote: >>> There was some discussion on what to do, but has there been a decision on >>> how to fix this yet? Or is it fixed upstream and

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Mon, Jun 2, 2014 at 10:44 AM, Yury Gribov wrote: >>> Why the -1 ? No ARM or Thumb instruction is 1 byte long. Instructions >>> are 4 bytes long if in ARM state and could be 2 or 4 bytes if Thumb >>> state. >> >> >> The -1 just points to the middle of previous instruction, >> so that supposedly

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

Why the -1 ? No ARM or Thumb instruction is 1 byte long. Instructions are 4 bytes long if in ARM state and could be 2 or 4 bytes if Thumb state. The -1 just points to the middle of previous instruction, so that supposedly it can be looked up in debug info etc. Right, that works quite well wit

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Mon, Jun 02, 2014 at 10:24:32AM +0100, Ramana Radhakrishnan wrote: > On Mon, Jun 2, 2014 at 8:56 AM, Jakub Jelinek wrote: > > On Mon, Jun 02, 2014 at 10:22:11AM +0400, Yury Gribov wrote: > >> Looks like now function does not return anything for ARM case? I'd > >> say we should replace this pc =

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Mon, Jun 2, 2014 at 8:56 AM, Jakub Jelinek wrote: > On Mon, Jun 02, 2014 at 10:22:11AM +0400, Yury Gribov wrote: >> Looks like now function does not return anything for ARM case? I'd >> say we should replace this pc = ... with return like all other >> cases, the code is just asking for trouble.

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On 06/02/2014 11:56 AM, Jakub Jelinek wrote: Looks like now function does not return anything for ARM case? I'd say we should replace this pc = ... with return like all other cases, the code is just asking for trouble. But it should be return (pc & ~(uptr)1) - 1; right? Yes, I had somethin

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Mon, Jun 02, 2014 at 10:22:11AM +0400, Yury Gribov wrote: > Looks like now function does not return anything for ARM case? I'd > say we should replace this pc = ... with return like all other > cases, the code is just asking for trouble. But it should be return (pc & ~(uptr)1) - 1; right? >

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

Looks like now function does not return anything for ARM case? I'd say we should replace this pc = ... with return like all other cases, the code is just asking for trouble. --- libsanitizer/sanitizer_common/sanitizer_stacktrace.cc (revision 209878) +++ libsanitizer/sanitizer_common/sani

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

There was some discussion on what to do, but has there been a decision on how to fix this yet? Or is it fixed upstream and we just need to merge that fix too? Yuri needs to send the patch to llvm-commits. I think I already did that: D3911 -Y

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Sat, May 31, 2014 at 11:53 PM, Peter Bergner wrote: > On Fri, 2014-05-30 at 15:49 +0200, Jakub Jelinek wrote: >> On Fri, May 30, 2014 at 08:09:22AM -0500, Peter Bergner wrote: >> > On Thu, 2014-05-29 at 14:07 -0500, Peter Bergner wrote: >> > > On Wed, 2014-05-28 at 09:36 +0200, Thomas Schwinge

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Fri, 2014-05-30 at 15:49 +0200, Jakub Jelinek wrote: > On Fri, May 30, 2014 at 08:09:22AM -0500, Peter Bergner wrote: > > On Thu, 2014-05-29 at 14:07 -0500, Peter Bergner wrote: > > > On Wed, 2014-05-28 at 09:36 +0200, Thomas Schwinge wrote: > > > > This is being discussed in the thread at > > >

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

Thanks Jakub! Looks like there is not rush with another merge now. --kcc On Fri, May 30, 2014 at 5:49 PM, Jakub Jelinek wrote: > On Fri, May 30, 2014 at 08:09:22AM -0500, Peter Bergner wrote: >> On Thu, 2014-05-29 at 14:07 -0500, Peter Bergner wrote: >> > On Wed, 2014-05-28 at 09:36 +0200, Thoma

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Fri, May 30, 2014 at 08:09:22AM -0500, Peter Bergner wrote: > On Thu, 2014-05-29 at 14:07 -0500, Peter Bergner wrote: > > On Wed, 2014-05-28 at 09:36 +0200, Thomas Schwinge wrote: > > > This is being discussed in the thread at > > > . Unt

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Thu, 2014-05-29 at 14:07 -0500, Peter Bergner wrote: > On Wed, 2014-05-28 at 09:36 +0200, Thomas Schwinge wrote: > > This is being discussed in the thread at > > . Until that > > has been resolved, I do agree to check in the following pat

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Wed, 2014-05-28 at 09:36 +0200, Thomas Schwinge wrote: > Hi! > > On Mon, 26 May 2014 18:53:22 +0800, Arseny Solokha wrote: > > Recent changes in GetPcSpBp() (libsanitizer/asan/asan_linux.cc) made it > > impossible to build 4.10.0-alpha20140525 snapshot for powerpc targets. > > I hit this, too

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

Hi! On Mon, 26 May 2014 18:53:22 +0800, Arseny Solokha wrote: > Recent changes in GetPcSpBp() (libsanitizer/asan/asan_linux.cc) made it > impossible to build 4.10.0-alpha20140525 snapshot for powerpc targets. I hit this, too. > The > proposed patch disables building libsanitizer for powerpc*-*-

Re: [PATCH] Do not build libsanitizer also for powerpc*-*-linux*

On Mon, May 26, 2014 at 2:53 PM, Arseny Solokha wrote: > Recent changes in GetPcSpBp() (libsanitizer/asan/asan_linux.cc) made it > impossible to build 4.10.0-alpha20140525 snapshot for powerpc targets. The > proposed patch disables building libsanitizer for powerpc*-*-linux* in > addition > to al