Re: [PATCH] DWARF5 DW_FORM_data16 support

2016-10-31 Thread Jason Merrill
On Mon, Oct 31, 2016 at 12:44 PM, Jakub Jelinek wrote: > On Mon, Oct 31, 2016 at 10:15:11AM -0400, Jason Merrill wrote: >> On 10/17/2016 05:39 PM, Jakub Jelinek wrote: >> >(dwarf_version >= 5 ? 128 : 64) >> >> Please make this a macro. OK with that change. > > DWARF_LARGEST_DATA_FORM_BITS ? Or d

Re: [PATCH] DWARF5 DW_FORM_data16 support

2016-10-31 Thread Jakub Jelinek
On Mon, Oct 31, 2016 at 10:15:11AM -0400, Jason Merrill wrote: > On 10/17/2016 05:39 PM, Jakub Jelinek wrote: > >(dwarf_version >= 5 ? 128 : 64) > > Please make this a macro. OK with that change. DWARF_LARGEST_DATA_FORM_BITS ? Or do you have better name? Jakub

Re: [PATCH] DWARF5 DW_FORM_data16 support

2016-10-31 Thread Jason Merrill
On 10/17/2016 05:39 PM, Jakub Jelinek wrote: (dwarf_version >= 5 ? 128 : 64) Please make this a macro. OK with that change. Jason