Re: [PATCH] Convert more passes to new dump framework

2013-12-21 Thread Xinliang David Li
thanks. David On Fri, Dec 20, 2013 at 11:48 PM, Sharad Singhai wrote: > Committed documentation as r206161. Sorry about the delay. > > Thanks, > Sharad > > On Thu, Nov 28, 2013 at 10:03 AM, Martin Jambor wrote: >> Hi, >> >> On Tue, Aug 06, 2013 at 10:18:05AM -0700, Sharad Singhai wrote: >>> On

Re: [PATCH] Convert more passes to new dump framework

2013-12-20 Thread Sharad Singhai
Committed documentation as r206161. Sorry about the delay. Thanks, Sharad On Thu, Nov 28, 2013 at 10:03 AM, Martin Jambor wrote: > Hi, > > On Tue, Aug 06, 2013 at 10:18:05AM -0700, Sharad Singhai wrote: >> On Tue, Aug 6, 2013 at 10:10 AM, Martin Jambor wrote: >> > On Tue, Aug 06, 2013 at 09:22:

Re: [PATCH] Convert more passes to new dump framework

2013-11-28 Thread Martin Jambor
Hi, On Tue, Aug 06, 2013 at 10:18:05AM -0700, Sharad Singhai wrote: > On Tue, Aug 6, 2013 at 10:10 AM, Martin Jambor wrote: > > On Tue, Aug 06, 2013 at 09:22:02AM -0700, Sharad Singhai wrote: > >> On Tue, Aug 6, 2013 at 8:57 AM, Xinliang David Li > >> wrote: > >> > On Tue, Aug 6, 2013 at 5:37 A

Re: [PATCH] Convert more passes to new dump framework

2013-09-04 Thread Richard Biener
On Tue, Sep 3, 2013 at 9:39 PM, Teresa Johnson wrote: > On Fri, Aug 30, 2013 at 11:28 PM, Sharad Singhai wrote: >>> Found the issue. The stream was incorrectly being closed when it was >>> stderr/stdout. So only the dump output before the first dump_finish >>> call was being emitted to stderr. I

Re: [PATCH] Convert more passes to new dump framework

2013-09-03 Thread Teresa Johnson
On Fri, Aug 30, 2013 at 11:28 PM, Sharad Singhai wrote: >> Found the issue. The stream was incorrectly being closed when it was >> stderr/stdout. So only the dump output before the first dump_finish >> call was being emitted to stderr. I fixed this the same way the >> alt_dump_file was being handl

Re: [PATCH] Convert more passes to new dump framework

2013-09-02 Thread Richard Biener
On Fri, Aug 30, 2013 at 11:23 PM, Teresa Johnson wrote: > On Fri, Aug 30, 2013 at 1:30 PM, Xinliang David Li wrote: >> On Fri, Aug 30, 2013 at 12:51 PM, Teresa Johnson >> wrote: >>> On Fri, Aug 30, 2013 at 9:27 AM, Xinliang David Li >>> wrote: Except that in this form, the dump will be e

Re: [PATCH] Convert more passes to new dump framework

2013-09-02 Thread Richard Biener
On Fri, Aug 30, 2013 at 9:51 PM, Teresa Johnson wrote: > On Fri, Aug 30, 2013 at 9:27 AM, Xinliang David Li wrote: >> Except that in this form, the dump will be extremely large and not >> suitable for very large applications. > > Yes. I did some measurements for both a fairly large source file th

Re: [PATCH] Convert more passes to new dump framework

2013-09-02 Thread Richard Biener
On Fri, Aug 30, 2013 at 6:27 PM, Xinliang David Li wrote: > Except that in this form, the dump will be extremely large and not > suitable for very large applications. So? You asked for it and you can easily grep the output before storing it away. > Besides, we might also want to > use the same

Re: [PATCH] Convert more passes to new dump framework

2013-08-31 Thread Teresa Johnson
On Sat, Aug 31, 2013 at 12:26 AM, Bernhard Reutner-Fischer wrote: > On 30 August 2013 23:23:16 Teresa Johnson wrote: >> >> On Fri, Aug 30, 2013 at 1:30 PM, Xinliang David Li >> wrote: >> > On Fri, Aug 30, 2013 at 12:51 PM, Teresa Johnson >> > wrote: >> >> On Fri, Aug 30, 2013 at 9:27 AM, Xinlia

Re: [PATCH] Convert more passes to new dump framework

2013-08-31 Thread Bernhard Reutner-Fischer
On 30 August 2013 23:23:16 Teresa Johnson wrote: On Fri, Aug 30, 2013 at 1:30 PM, Xinliang David Li wrote: > On Fri, Aug 30, 2013 at 12:51 PM, Teresa Johnson wrote: >> On Fri, Aug 30, 2013 at 9:27 AM, Xinliang David Li wrote: >>> Except that in this form, the dump will be extremely large a

Re: [PATCH] Convert more passes to new dump framework

2013-08-30 Thread Sharad Singhai
On Fri, Aug 30, 2013 at 9:58 PM, Teresa Johnson wrote: > Besides, we might also want to > use the same machinery (dump_printf_loc etc) for dump file dumping. > The current behavior of using '-details' to turn on opt-info-all > messages for dump files are not desirable. In

Re: [PATCH] Convert more passes to new dump framework

2013-08-30 Thread Teresa Johnson
Besides, we might also want to use the same machinery (dump_printf_loc etc) for dump file dumping. The current behavior of using '-details' to turn on opt-info-all messages for dump files are not desirable. >>> >>> Interestingly, this doesn't even work. When I do >>> -fdump-ipa-

Re: [PATCH] Convert more passes to new dump framework

2013-08-30 Thread Teresa Johnson
On Fri, Aug 30, 2013 at 1:30 PM, Xinliang David Li wrote: > On Fri, Aug 30, 2013 at 12:51 PM, Teresa Johnson wrote: >> On Fri, Aug 30, 2013 at 9:27 AM, Xinliang David Li >> wrote: >>> Except that in this form, the dump will be extremely large and not >>> suitable for very large applications. >>

Re: [PATCH] Convert more passes to new dump framework

2013-08-30 Thread Xinliang David Li
On Fri, Aug 30, 2013 at 12:51 PM, Teresa Johnson wrote: > On Fri, Aug 30, 2013 at 9:27 AM, Xinliang David Li wrote: >> Except that in this form, the dump will be extremely large and not >> suitable for very large applications. > > Yes. I did some measurements for both a fairly large source file t

Re: [PATCH] Convert more passes to new dump framework

2013-08-30 Thread Teresa Johnson
On Fri, Aug 30, 2013 at 9:27 AM, Xinliang David Li wrote: > Except that in this form, the dump will be extremely large and not > suitable for very large applications. Yes. I did some measurements for both a fairly large source file that is heavily optimized with LIPO and for a simple toy example

Re: [PATCH] Convert more passes to new dump framework

2013-08-30 Thread Xinliang David Li
Except that in this form, the dump will be extremely large and not suitable for very large applications. Besides, we might also want to use the same machinery (dump_printf_loc etc) for dump file dumping. The current behavior of using '-details' to turn on opt-info-all messages for dump files are no

Re: [PATCH] Convert more passes to new dump framework

2013-08-30 Thread Teresa Johnson
Sorry, I should not have committed that new test along with this portion of the patch. Removed as of r202106. Teresa On Fri, Aug 30, 2013 at 12:17 AM, Andreas Schwab wrote: > Teresa Johnson writes: > >> Index: testsuite/gcc.dg/inline-dump.c >>

Re: [PATCH] Convert more passes to new dump framework

2013-08-30 Thread Richard Biener
On Thu, Aug 29, 2013 at 5:15 PM, Teresa Johnson wrote: > On Thu, Aug 29, 2013 at 3:04 AM, Richard Biener > wrote: > New patch below that removes this global variable, and also outputs > the node->symbol.order (in square brackets after the function name so > as to not clutter it). Inli

Re: [PATCH] Convert more passes to new dump framework

2013-08-30 Thread Andreas Schwab
Teresa Johnson writes: > Index: testsuite/gcc.dg/inline-dump.c > === > --- testsuite/gcc.dg/inline-dump.c (revision 0) > +++ testsuite/gcc.dg/inline-dump.c (revision 0) > @@ -0,0 +1,11 @@ > +/* Verify that -fopt-info can ou

Re: [PATCH] Convert more passes to new dump framework

2013-08-29 Thread Teresa Johnson
On Wed, Aug 28, 2013 at 7:09 AM, Teresa Johnson wrote: >> The inline stuff should be split and re-sent, it's non-obvious to me (extra >> function parameters are not documented for example). I'd rather have >> inline_and_report_call () for example instead of an extra bool parameter. >> But let's i

Re: [PATCH] Convert more passes to new dump framework

2013-08-29 Thread Teresa Johnson
On Thu, Aug 29, 2013 at 3:04 AM, Richard Biener wrote: New patch below that removes this global variable, and also outputs the node->symbol.order (in square brackets after the function name so as to not clutter it). Inline messages with profile data look look: test.c:8:3:

Re: [PATCH] Convert more passes to new dump framework

2013-08-29 Thread Richard Biener
Ok. Richard. On Thu, Aug 29, 2013 at 3:18 PM, Teresa Johnson wrote: > On Wed, Aug 28, 2013 at 9:07 AM, Teresa Johnson wrote: >> On Wed, Aug 28, 2013 at 7:09 AM, Teresa Johnson wrote: >>> On Wed, Aug 28, 2013 at 4:01 AM, Richard Biener >>> wrote: On Wed, Aug 7, 2013 at 7:23 AM, Teresa Joh

Re: [PATCH] Convert more passes to new dump framework

2013-08-29 Thread Teresa Johnson
On Thu, Aug 29, 2013 at 3:05 AM, Richard Biener wrote: Does 'make newlines consitent' avoid all the spurious vertical spacing I see with -fopt-info? >>> >>> Well, it helps get us there. The problem was that before, since >>> dump_loc was not consistently emitting newlines, the

Re: [PATCH] Convert more passes to new dump framework

2013-08-29 Thread Teresa Johnson
On Wed, Aug 28, 2013 at 9:07 AM, Teresa Johnson wrote: > On Wed, Aug 28, 2013 at 7:09 AM, Teresa Johnson wrote: >> On Wed, Aug 28, 2013 at 4:01 AM, Richard Biener >> wrote: >>> On Wed, Aug 7, 2013 at 7:23 AM, Teresa Johnson wrote: On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote

Re: [PATCH] Convert more passes to new dump framework

2013-08-29 Thread Richard Biener
On Wed, Aug 28, 2013 at 5:20 PM, Xinliang David Li wrote: > On Wed, Aug 28, 2013 at 7:09 AM, Teresa Johnson wrote: >> On Wed, Aug 28, 2013 at 4:01 AM, Richard Biener >> wrote: >>> On Wed, Aug 7, 2013 at 7:23 AM, Teresa Johnson wrote: On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wr

Re: [PATCH] Convert more passes to new dump framework

2013-08-29 Thread Richard Biener
On Wed, Aug 28, 2013 at 4:09 PM, Teresa Johnson wrote: > On Wed, Aug 28, 2013 at 4:01 AM, Richard Biener > wrote: >> On Wed, Aug 7, 2013 at 7:23 AM, Teresa Johnson wrote: >>> On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote: On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote: > H

Re: [PATCH] Convert more passes to new dump framework

2013-08-28 Thread Teresa Johnson
On Wed, Aug 28, 2013 at 7:09 AM, Teresa Johnson wrote: > On Wed, Aug 28, 2013 at 4:01 AM, Richard Biener > wrote: >> On Wed, Aug 7, 2013 at 7:23 AM, Teresa Johnson wrote: >>> On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote: On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote: > H

Re: [PATCH] Convert more passes to new dump framework

2013-08-28 Thread Xinliang David Li
On Wed, Aug 28, 2013 at 7:09 AM, Teresa Johnson wrote: > On Wed, Aug 28, 2013 at 4:01 AM, Richard Biener > wrote: >> On Wed, Aug 7, 2013 at 7:23 AM, Teresa Johnson wrote: >>> On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote: On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote: > H

Re: [PATCH] Convert more passes to new dump framework

2013-08-28 Thread Teresa Johnson
On Wed, Aug 28, 2013 at 4:01 AM, Richard Biener wrote: > On Wed, Aug 7, 2013 at 7:23 AM, Teresa Johnson wrote: >> On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote: >>> On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote: Hi, On Tue, Aug 06, 2013 at 07:14:42AM -0700, Teresa Jo

Re: [PATCH] Convert more passes to new dump framework

2013-08-28 Thread Richard Biener
On Wed, Aug 7, 2013 at 7:23 AM, Teresa Johnson wrote: > On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote: >> On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote: >>> Hi, >>> >>> On Tue, Aug 06, 2013 at 07:14:42AM -0700, Teresa Johnson wrote: On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor

Re: [PATCH] Convert more passes to new dump framework

2013-08-27 Thread Xinliang David Li
+ Honza On Tue, Aug 27, 2013 at 10:56 AM, Teresa Johnson wrote: > Ping #3. > > Thanks, > Teresa > > On Mon, Aug 19, 2013 at 11:33 AM, Teresa Johnson wrote: >> Ping. >> Thanks, >> Teresa >> >> On Mon, Aug 12, 2013 at 6:54 AM, Teresa Johnson wrote: >>> On Tue, Aug 6, 2013 at 10:23 PM, Teresa John

Re: [PATCH] Convert more passes to new dump framework

2013-08-27 Thread Teresa Johnson
Ping #3. Thanks, Teresa On Mon, Aug 19, 2013 at 11:33 AM, Teresa Johnson wrote: > Ping. > Thanks, > Teresa > > On Mon, Aug 12, 2013 at 6:54 AM, Teresa Johnson wrote: >> On Tue, Aug 6, 2013 at 10:23 PM, Teresa Johnson wrote: >>> On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote: On Tue

Re: [PATCH] Convert more passes to new dump framework

2013-08-19 Thread Teresa Johnson
Ping. Thanks, Teresa On Mon, Aug 12, 2013 at 6:54 AM, Teresa Johnson wrote: > On Tue, Aug 6, 2013 at 10:23 PM, Teresa Johnson wrote: >> On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote: >>> On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote: Hi, On Tue, Aug 06, 2013 at 07:1

Re: [PATCH] Convert more passes to new dump framework

2013-08-12 Thread Teresa Johnson
On Tue, Aug 6, 2013 at 10:23 PM, Teresa Johnson wrote: > On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote: >> On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote: >>> Hi, >>> >>> On Tue, Aug 06, 2013 at 07:14:42AM -0700, Teresa Johnson wrote: On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambo

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Teresa Johnson
On Tue, Aug 6, 2013 at 9:29 AM, Teresa Johnson wrote: > On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote: >> Hi, >> >> On Tue, Aug 06, 2013 at 07:14:42AM -0700, Teresa Johnson wrote: >>> On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote: >>> > On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teres

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Xinliang David Li
yes -- if this is the place developers look at the most. David On Tue, Aug 6, 2013 at 10:18 AM, Sharad Singhai wrote: > On Tue, Aug 6, 2013 at 10:10 AM, Martin Jambor wrote: >> On Tue, Aug 06, 2013 at 09:22:02AM -0700, Sharad Singhai wrote: >>> On Tue, Aug 6, 2013 at 8:57 AM, Xinliang David Li

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Sharad Singhai
On Tue, Aug 6, 2013 at 10:10 AM, Martin Jambor wrote: > On Tue, Aug 06, 2013 at 09:22:02AM -0700, Sharad Singhai wrote: >> On Tue, Aug 6, 2013 at 8:57 AM, Xinliang David Li wrote: >> > On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote: >> >> Hi, >> >> >> >> On Mon, Aug 05, 2013 at 10:37:00PM -

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Martin Jambor
On Tue, Aug 06, 2013 at 09:22:02AM -0700, Sharad Singhai wrote: > On Tue, Aug 6, 2013 at 8:57 AM, Xinliang David Li wrote: > > On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote: > >> Hi, > >> > >> On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote: > >>> This patch ports messages to

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Teresa Johnson
On Tue, Aug 6, 2013 at 9:01 AM, Martin Jambor wrote: > Hi, > > On Tue, Aug 06, 2013 at 07:14:42AM -0700, Teresa Johnson wrote: >> On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote: >> > On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote: >> >> This patch ports messages to the new du

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Sharad Singhai
On Tue, Aug 6, 2013 at 8:57 AM, Xinliang David Li wrote: > On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote: >> Hi, >> >> On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote: >>> This patch ports messages to the new dump framework, >> >> It would be great this new framework was docu

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Martin Jambor
Hi, On Tue, Aug 06, 2013 at 07:14:42AM -0700, Teresa Johnson wrote: > On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote: > > On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote: > >> This patch ports messages to the new dump framework, > > > > It would be great this new framework was

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Xinliang David Li
On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote: > Hi, > > On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote: >> This patch ports messages to the new dump framework, > > It would be great this new framework was documented somewhere. I lost > track of what was agreed it would be a

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Teresa Johnson
On Tue, Aug 6, 2013 at 5:37 AM, Martin Jambor wrote: > Hi, > > On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote: >> This patch ports messages to the new dump framework, > > It would be great this new framework was documented somewhere. I lost > track of what was agreed it would be a

Re: [PATCH] Convert more passes to new dump framework

2013-08-06 Thread Martin Jambor
Hi, On Mon, Aug 05, 2013 at 10:37:00PM -0700, Teresa Johnson wrote: > This patch ports messages to the new dump framework, It would be great this new framework was documented somewhere. I lost track of what was agreed it would be and from the uses in the vectorizer I was never quite sure how to