Re: [PATCH] Clean up shrink-wrapping codes

2014-05-14 Thread Jeff Law
On 05/13/14 02:13, Marek Polacek wrote: On Tue, May 13, 2014 at 04:08:21PM +0800, Zhenqiang Chen wrote: On 13 May 2014 15:55, Marek Polacek wrote: On Tue, May 13, 2014 at 03:14:34PM +0800, Zhenqiang Chen wrote: Thanks. Committed the patch @r210351 with changes: (1) Create shrink-wrap.h. (2) M

Re: [PATCH] Clean up shrink-wrapping codes

2014-05-13 Thread Zhenqiang Chen
On 13 May 2014 16:13, Marek Polacek wrote: > On Tue, May 13, 2014 at 04:08:21PM +0800, Zhenqiang Chen wrote: >> On 13 May 2014 15:55, Marek Polacek wrote: >> > On Tue, May 13, 2014 at 03:14:34PM +0800, Zhenqiang Chen wrote: >> >> Thanks. Committed the patch @r210351 with changes: >> >> (1) Create

Re: [PATCH] Clean up shrink-wrapping codes

2014-05-13 Thread Marek Polacek
On Tue, May 13, 2014 at 04:08:21PM +0800, Zhenqiang Chen wrote: > On 13 May 2014 15:55, Marek Polacek wrote: > > On Tue, May 13, 2014 at 03:14:34PM +0800, Zhenqiang Chen wrote: > >> Thanks. Committed the patch @r210351 with changes: > >> (1) Create shrink-wrap.h. > >> (2) Move all shrink-wrapping

Re: [PATCH] Clean up shrink-wrapping codes

2014-05-13 Thread Zhenqiang Chen
On 13 May 2014 15:55, Marek Polacek wrote: > On Tue, May 13, 2014 at 03:14:34PM +0800, Zhenqiang Chen wrote: >> Thanks. Committed the patch @r210351 with changes: >> (1) Create shrink-wrap.h. >> (2) Move all shrink-wrapping related interfaces from function.h to >> shrink-wrap.h. >> (3) shrink-wrap

Re: [PATCH] Clean up shrink-wrapping codes

2014-05-13 Thread Marek Polacek
On Tue, May 13, 2014 at 03:14:34PM +0800, Zhenqiang Chen wrote: > Thanks. Committed the patch @r210351 with changes: > (1) Create shrink-wrap.h. > (2) Move all shrink-wrapping related interfaces from function.h to > shrink-wrap.h. > (3) shrink-wrap.h is included in function.c, shrink-wrap.c and > c

Re: [PATCH] Clean up shrink-wrapping codes

2014-05-12 Thread Jeff Law
On 05/12/14 02:02, Zhenqiang Chen wrote: Hi, According to Steven and Jeff's comments, the patch cleans up most shrink-wrapping codes from function.c to new added shrink-wrap.c. Changes include: (1) Move functions requires_stack_frame_p, next_block_for_reg, move_insn_for_shrink_wrap, prepare_shr