Re: [PATCH] C++: simplify output from suggest_alternatives_for

2018-10-10 Thread Jason Merrill
On Tue, Oct 9, 2018 at 1:19 PM David Malcolm wrote: > + if (!DECL_P (decl) > + && decl == error_mark_node) You don't need to check DECL_P here. Jason

Re: [PATCH] C++: simplify output from suggest_alternatives_for

2018-10-09 Thread Jason Merrill
On Tue, Oct 9, 2018 at 1:19 PM David Malcolm wrote: > + /* Emulation of a "move" constructor, but really a copy > + constructor. */ > + > + name_hint (const name_hint &other) > + : m_suggestion (other.m_suggestion), > +m_deferred (const_cast (other).take_deferred ()) > + { > + } > +