Re: [PATCH] Avoid visiting newly-created blocks in harden-conditionals

2022-05-13 Thread Alexandre Oliva via Gcc-patches
On May 13, 2022, Richard Biener wrote: > Yeah, I'm not sure who clears that bit - grepping shows no user > besides the setter... *nod*, that's what I'd found out myself. Oh well... >> Though I suppose it might be useful to document and enforce the property >> that a newly-created block takes u

Re: [PATCH] Avoid visiting newly-created blocks in harden-conditionals

2022-05-13 Thread Richard Biener via Gcc-patches
On Fri, May 13, 2022 at 9:47 AM Alexandre Oliva wrote: > > On May 12, 2022, Richard Biener wrote: > > > Note you are relying on an implementation detail here, it might be > > better to mark blocks visited or iterate over the CFG in a more > > defined manner > > *nod*, I was wondering whether that

Re: [PATCH] Avoid visiting newly-created blocks in harden-conditionals

2022-05-13 Thread Alexandre Oliva via Gcc-patches
On May 12, 2022, Richard Biener wrote: > Note you are relying on an implementation detail here, it might be > better to mark blocks visited or iterate over the CFG in a more > defined manner *nod*, I was wondering whether that property could be relied on. I also see BB_NEW set in bb->flags in t

Re: [PATCH] Avoid visiting newly-created blocks in harden-conditionals

2022-05-12 Thread Richard Biener via Gcc-patches
On Thu, May 12, 2022 at 3:47 AM Alexandre Oliva via Gcc-patches wrote: > > > Reverse iteration over blocks, in gimple-harden-conditionals.cc, was > supposed to avoid visiting blocks introduced by hardening and > introducing further reversed conditionals and traps for them, but > newly-created bloc