Re: [PATCH] Avoid static initialization in the strlen pass

2017-11-21 Thread Martin Sebor
On 11/20/2017 02:57 PM, Jakub Jelinek wrote: On Mon, Nov 20, 2017 at 02:25:35PM -0700, Martin Sebor wrote: On 11/20/2017 02:14 PM, Jakub Jelinek wrote: Hi! All the hash_maps in tree-ssa-strlen.c except for the newly added one were pointers to hash maps, which were constructed either lazily or

Re: [PATCH] Avoid static initialization in the strlen pass

2017-11-21 Thread Richard Biener
On Mon, 20 Nov 2017, Jakub Jelinek wrote: > Hi! > > All the hash_maps in tree-ssa-strlen.c except for the newly added one > were pointers to hash maps, which were constructed either lazily or during > the pass. But strlen_to_stridx is now constructed at the compiler start, > which is something I

Re: [PATCH] Avoid static initialization in the strlen pass

2017-11-20 Thread Jakub Jelinek
On Mon, Nov 20, 2017 at 02:25:35PM -0700, Martin Sebor wrote: > On 11/20/2017 02:14 PM, Jakub Jelinek wrote: > > Hi! > > > > All the hash_maps in tree-ssa-strlen.c except for the newly added one > > were pointers to hash maps, which were constructed either lazily or during > > the pass. But strle

Re: [PATCH] Avoid static initialization in the strlen pass

2017-11-20 Thread Martin Sebor
On 11/20/2017 02:14 PM, Jakub Jelinek wrote: Hi! All the hash_maps in tree-ssa-strlen.c except for the newly added one were pointers to hash maps, which were constructed either lazily or during the pass. But strlen_to_stridx is now constructed at the compiler start, which is something I'd prefe