Re: [PATCH] Add support for KernelAddressSanitizer

2014-07-23 Thread Yury Gribov
On 07/18/2014 05:38 PM, Jakub Jelinek wrote: Do you error out on -fsanitize=thread -fsanitize=kernel-address ? Perhaps -fsanitize=kernel-address -fsanitize=address should be invalid too? Yes, all these combinations are invalid. But you don't error out on that. Ok, fixed. Then in sanitize_

Re: [PATCH] Add support for KernelAddressSanitizer

2014-07-18 Thread Yury Gribov
Then in sanitize_spec_function supposedly for "address" check SANITIZE_USER_ADDRESS bit, for "kernel-address" added there SANITIZE_KERNEL_ADDRESS, add all the incompatibility diagnostics for the new invalid combinations. Ok. Plus, toplev.c has e.g.: ... Now, is the same really the case for SAN

Re: [PATCH] Add support for KernelAddressSanitizer

2014-07-18 Thread Jakub Jelinek
On Fri, Jul 18, 2014 at 05:19:39PM +0400, Dmitry Vyukov wrote: > On Fri, Jul 18, 2014 at 4:26 PM, Jakub Jelinek wrote: > > On Fri, Jul 18, 2014 at 03:40:15PM +0400, Yury Gribov wrote: > >> This tiny patch adds support for KernelASan. KASan brings Asan error > >> detection capabilities to Linux ker

Re: [PATCH] Add support for KernelAddressSanitizer

2014-07-18 Thread Yury Gribov
>> Also, oring in SANITIZER_ADDRESS means you add -lasan to link flags, I'd >> guess that for -fsanitize=kernel-address you don't want to add any libraries >> at link time? > > I suspect that we don't pass -fsanitize=kernel-address during linking > in kernel today. But I agree that it's better t

Re: [PATCH] Add support for KernelAddressSanitizer

2014-07-18 Thread Dmitry Vyukov
On Fri, Jul 18, 2014 at 4:26 PM, Jakub Jelinek wrote: > On Fri, Jul 18, 2014 at 03:40:15PM +0400, Yury Gribov wrote: >> This tiny patch adds support for KernelASan. KASan brings Asan error >> detection capabilities to Linux kernel >> (https://code.google.com/p/address-sanitizer/wiki/AddressSanitiz

Re: [PATCH] Add support for KernelAddressSanitizer

2014-07-18 Thread Jakub Jelinek
On Fri, Jul 18, 2014 at 03:40:15PM +0400, Yury Gribov wrote: > This tiny patch adds support for KernelASan. KASan brings Asan error > detection capabilities to Linux kernel > (https://code.google.com/p/address-sanitizer/wiki/AddressSanitizerForKernel). > > KASan works similar to normal userspace A

Re: [PATCH] Add support for KernelAddressSanitizer

2014-07-18 Thread Dmitry Vyukov
On Fri, Jul 18, 2014 at 3:40 PM, Yury Gribov wrote: > Hi all, > > This tiny patch adds support for KernelASan. KASan brings Asan error > detection capabilities to Linux kernel > (https://code.google.com/p/address-sanitizer/wiki/AddressSanitizerForKernel). > > KASan works similar to normal userspac