Re: [PATCH] Add header guard to several header files.

2014-09-18 Thread Joseph S. Myers
On Fri, 19 Sep 2014, Kito Cheng wrote: > Hi Joseph: > > Here is updated patch and ChangeLog, > > However I don't have commit write yet, can you help me to commit it? thanks Committed. -- Joseph S. Myers jos...@codesourcery.com

Re: [PATCH] Add header guard to several header files.

2014-09-18 Thread Kito Cheng
Hi Joseph: Here is updated patch and ChangeLog, However I don't have commit write yet, can you help me to commit it? thanks btw, I has already signed FSF agreement:) 2014-09-19 Kito Cheng except.h: Fix header guard. addresses.h: Add missing header guard. cfghooks.h: Likewise.

Re: [PATCH] Add header guard to several header files.

2014-09-17 Thread Joseph S. Myers
On Wed, 17 Sep 2014, Kito Cheng wrote: > Updated patch OK except for the changes to target-def.h and target-hooks-macros.h. (Those aren't exactly normal headers that could reasonably be included more than once in a source file; they have dependencies on where they get included and what's defi

Re: [PATCH] Add header guard to several header files.

2014-09-17 Thread Kito Cheng
Updated patch On Wed, Sep 17, 2014 at 9:17 PM, Kito Cheng wrote: > Updated patch > > On Mon, Sep 8, 2014 at 9:46 PM, Kito Cheng wrote: >> >> ping! >> >> On Tue, Sep 2, 2014 at 12:37 AM, Kito Cheng wrote: >> > Hi Joseph: >> > >> > Thanks for your review, I've reverted the part of gsyslimits.h, >

Re: [PATCH] Add header guard to several header files.

2014-09-08 Thread Kito Cheng
ping! On Tue, Sep 2, 2014 at 12:37 AM, Kito Cheng wrote: > Hi Joseph: > > Thanks for your review, I've reverted the part of gsyslimits.h, > here is updated patch and ChangeLog :) > > bootstrap ok for x86_64 > > 2014-09-01 Kito Cheng > > except.h: Fix header guard. > addresses.h: Add mi

Re: [PATCH] Add header guard to several header files.

2014-09-01 Thread Kito Cheng
Hi Joseph: Thanks for your review, I've reverted the part of gsyslimits.h, here is updated patch and ChangeLog :) bootstrap ok for x86_64 2014-09-01 Kito Cheng except.h: Fix header guard. addresses.h: Add missing header guard. cfghooks.h: Likewise. collect-utils.h: Likewise.

Re: [PATCH] Add header guard to several header files.

2014-09-01 Thread Joseph S. Myers
On Mon, 1 Sep 2014, Kito Cheng wrote: > gsyslimits.h: Likewise. This is incorrect. This is a very special header file, installed as part of the implementation of ; it certainly can't use any user-namespace identifiers, and it's probably not safe for it to have header guards at all. -- J

Re: [PATCH] Add header guard to several header files.

2014-08-31 Thread Kito Cheng
Oops, ChangeLog here: ChangeLog 2014-09-01 Kito Cheng except.h: Fix header guard. addresses.h: Add missing header guard. cfghooks.h: Likewise. collect-utils.h: Likewise. collect2-aix.h: Likewise. conditions.h: Likewise. cselib.h: Likewise. dwarf2asm.h: Likewise.