Re: [PATCH] Add guality [p]type test.

2014-08-20 Thread Richard Biener
On Wed, Aug 20, 2014 at 2:19 PM, Mark Wielaard wrote: > On Wed, 2014-08-20 at 10:49 +0200, Richard Biener wrote: >> On Tue, Aug 19, 2014 at 7:52 PM, Mark Wielaard wrote: >> > Filed as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62190 "LTO DWARF >> > produces __unknown__ type for unsigned int fun

Re: [PATCH] Add guality [p]type test.

2014-08-20 Thread Mark Wielaard
On Wed, 2014-08-20 at 10:49 +0200, Richard Biener wrote: > On Tue, Aug 19, 2014 at 7:52 PM, Mark Wielaard wrote: > > Filed as https://gcc.gnu.org/bugzilla/show_bug.cgi?id=62190 "LTO DWARF > > produces __unknown__ type for unsigned int function argument type". > > > > I included a smaller testcase

Re: [PATCH] Add guality [p]type test.

2014-08-20 Thread Richard Biener
On Tue, Aug 19, 2014 at 7:52 PM, Mark Wielaard wrote: > On Tue, 2014-08-19 at 14:16 +0200, Richard Biener wrote: >> On Tue, Aug 19, 2014 at 2:10 PM, Mark Wielaard wrote: >> > gcc/testsuite/ChangeLog >> > 2014-08-19 Mark Wielaard >> > >> > * gcc.dg/guality/restrict.c: Add `used' attribute t

Re: [PATCH] Add guality [p]type test.

2014-08-19 Thread Mark Wielaard
On Tue, 2014-08-19 at 14:16 +0200, Richard Biener wrote: > On Tue, Aug 19, 2014 at 2:10 PM, Mark Wielaard wrote: > > gcc/testsuite/ChangeLog > > 2014-08-19 Mark Wielaard > > > > * gcc.dg/guality/restrict.c: Add `used' attribute to all variables. > > (cpy): Change type of last argument t

Re: [PATCH] Add guality [p]type test.

2014-08-19 Thread Richard Biener
On Tue, Aug 19, 2014 at 2:10 PM, Mark Wielaard wrote: > On Tue, 2014-08-19 at 13:22 +0200, Richard Biener wrote: >> On Tue, Aug 19, 2014 at 1:05 PM, Mark Wielaard wrote: >> > On Mon, 2014-07-07 at 11:57 +0200, Richard Biener wrote: >> >> Btw, why doesn't it succeed with LTO? I suspect it's becau

Re: [PATCH] Add guality [p]type test.

2014-08-19 Thread Mark Wielaard
On Tue, 2014-08-19 at 13:22 +0200, Richard Biener wrote: > On Tue, Aug 19, 2014 at 1:05 PM, Mark Wielaard wrote: > > On Mon, 2014-07-07 at 11:57 +0200, Richard Biener wrote: > >> Btw, why doesn't it succeed with LTO? I suspect it's because > >> we drop the unused variables - try adding __attribut

Re: [PATCH] Add guality [p]type test.

2014-08-19 Thread Richard Biener
On Tue, Aug 19, 2014 at 1:05 PM, Mark Wielaard wrote: > On Mon, 2014-07-07 at 11:57 +0200, Richard Biener wrote: >> Btw, why doesn't it succeed with LTO? I suspect it's because >> we drop the unused variables - try adding __attribute__((used)) to >> them. > > You are right, this makes the whole n

Re: [PATCH] Add guality [p]type test.

2014-08-19 Thread Mark Wielaard
On Mon, 2014-07-07 at 11:57 +0200, Richard Biener wrote: > Btw, why doesn't it succeed with LTO? I suspect it's because > we drop the unused variables - try adding __attribute__((used)) to > them. You are right, this makes the whole new test PASS also with LTO: 2014-08-19 Mark Wielaard *

Re: [PATCH] Add guality [p]type test.

2014-07-07 Thread Richard Biener
On Thu, Jul 3, 2014 at 11:53 AM, Mark Wielaard wrote: > Hi, > > I pulled out the guality.exp [p]type test extension from the actual > dwarf2out.c changes (which I will repost soon with some tweaks). I think > the test extension itself is useful on its own (and will use it to > add tests for my new

Re: [PATCH] Add guality [p]type test.

2014-07-03 Thread Tom Tromey
>> Is what gdb prints for ptype stable across different gdb versions (except >> for whitespace that you canonicalize)? If yes, this looks good to me. Mark> Yes, I believe it is (I tested against gdb git master and gdb 7.6.50). Mark> It tries to print the expression as a canonical C type, so it sh

Re: [PATCH] Add guality [p]type test.

2014-07-03 Thread Mark Wielaard
On Thu, 2014-07-03 at 12:05 +0200, Jakub Jelinek wrote: > On Thu, Jul 03, 2014 at 11:53:29AM +0200, Mark Wielaard wrote: > > I pulled out the guality.exp [p]type test extension from the actual > > dwarf2out.c changes (which I will repost soon with some tweaks). I think > > the test extension itself

Re: [PATCH] Add guality [p]type test.

2014-07-03 Thread Jakub Jelinek
On Thu, Jul 03, 2014 at 11:53:29AM +0200, Mark Wielaard wrote: > I pulled out the guality.exp [p]type test extension from the actual > dwarf2out.c changes (which I will repost soon with some tweaks). I think > the test extension itself is useful on its own (and will use it to > add tests for my new