Re: [PATCH] Add explicit default constructors where required by the standard

On 2013-05-22 05:32 , Evgeniy Stepanov wrote: OK to merge to google/4_7 and google/4_8? Yes. Patches coming from trunk or other release branches need no further approval for backporting. You just need to make sure you don't introduce any regressions, of course. Diego.

Re: [PATCH] Add explicit default constructors where required by the standard

OK to merge to google/4_7 and google/4_8? On Wed, May 15, 2013 at 12:28 PM, Evgeniy Stepanov wrote: > Thanks! > > On Wed, May 15, 2013 at 3:05 AM, Jonathan Wakely > wrote: >> On 14 May 2013 10:56, Jonathan Wakely wrote: >>> On 14 May 2013 10:45, Evgeniy Stepanov wrote: This must have falle

Re: [PATCH] Add explicit default constructors where required by the standard

Thanks! On Wed, May 15, 2013 at 3:05 AM, Jonathan Wakely wrote: > On 14 May 2013 10:56, Jonathan Wakely wrote: >> On 14 May 2013 10:45, Evgeniy Stepanov wrote: >>> This must have fallen through the cracks. >> >> It's still in my Git branch at home. I've been too busy to push any >> commits recent

Re: [PATCH] Add explicit default constructors where required by the standard

On 14 May 2013 10:56, Jonathan Wakely wrote: > On 14 May 2013 10:45, Evgeniy Stepanov wrote: >> This must have fallen through the cracks. > > It's still in my Git branch at home. I've been too busy to push any > commits recently, but I haven't forgotten it. > > >> I realized we also need it in the

Re: [PATCH] Add explicit default constructors where required by the standard

On 14 May 2013 10:45, Evgeniy Stepanov wrote: > This must have fallen through the cracks. It's still in my Git branch at home. I've been too busy to push any commits recently, but I haven't forgotten it. > I realized we also need it in the 4_7 branch. Could you backport the > change there, too,

Re: [PATCH] Add explicit default constructors where required by the standard

This must have fallen through the cracks. I realized we also need it in the 4_7 branch. Could you backport the change there, too, if it is not too much trouble? On Mon, Apr 22, 2013 at 10:53 PM, Jonathan Wakely wrote: > On 22 April 2013 12:13, Evgeniy Stepanov wrote: >> Thanks a lot. >> Forgot to

Re: [PATCH] Add explicit default constructors where required by the standard

On 22 April 2013 12:13, Evgeniy Stepanov wrote: > Thanks a lot. > Forgot to mention it earlier, can this be backported in the 4_8 branch as > well? Yes, I don't see why not. I'll do that too.

Re: [PATCH] Add explicit default constructors where required by the standard

Thanks a lot. Forgot to mention it earlier, can this be backported in the 4_8 branch as well? On Sun, Apr 21, 2013 at 12:40 PM, Jonathan Wakely wrote: > On 19 April 2013 16:19, Evgeniy Stepanov wrote: >> Good point, thanks! >> Revised patch attached. > > I've committed that version, thanks very m

Re: [PATCH] Add explicit default constructors where required by the standard

On 19 April 2013 16:19, Evgeniy Stepanov wrote: > Good point, thanks! > Revised patch attached. I've committed that version, thanks very much. > On Fri, Apr 19, 2013 at 7:00 PM, Jonathan Wakely > wrote: >> On 19 April 2013 15:42, Evgeniy Stepanov wrote: >>> Hi, >>> >>> according to n3242 8.5.6

Re: [PATCH] Add explicit default constructors where required by the standard

Good point, thanks! Revised patch attached. On Fri, Apr 19, 2013 at 7:00 PM, Jonathan Wakely wrote: > On 19 April 2013 15:42, Evgeniy Stepanov wrote: >> Hi, >> >> according to n3242 8.5.6, >> >> If a program calls for the default initialization of an object of a >> const-qualified type T, T shall

Re: [PATCH] Add explicit default constructors where required by the standard

On 19 April 2013 15:42, Evgeniy Stepanov wrote: > Hi, > > according to n3242 8.5.6, > > If a program calls for the default initialization of an object of a > const-qualified type T, T shall be a class type with a user-provided > default constructor. > > This patches fixes 3 places in libstdc++ code