On 09/16/2017 09:35 AM, Bernhard Reutner-Fischer wrote:
+ * for result-adjusting thinks, the FIXED_OFFSET adjustment is done after
s/think/thunk/
TIA
Good catch, thank you! I just pushed the following obvious change, as
r252904:
Fix a typo in a comment (cgraph.c:cgraph_thunk_info)
On 15 September 2017 18:20:33 CEST, Pierre-Marie de Rodat
wrote:
>On 09/15/2017 06:10 PM, Jeff Law wrote:
>> OK.
>> jeff
>
>Committed. Thanks!
+ * for result-adjusting thinks, the FIXED_OFFSET adjustment is done after
s/think/thunk/
TIA
On 09/15/2017 06:10 PM, Jeff Law wrote:
OK.
jeff
Committed. Thanks!
--
Pierre-Marie de Rodat
On 09/15/2017 08:48 AM, Pierre-Marie de Rodat wrote:
> On 09/15/2017 12:54 PM, Pierre-Marie de Rodat wrote:
>> I’m not super confident about this though, so I’ll resubmit a patch
>> without the reordering: I’ve added more comments anyway as I’ve
>> learned more about this since yesterday. ;-)
>
>
On 09/15/2017 12:54 PM, Pierre-Marie de Rodat wrote:
I’m not super confident about this though, so I’ll resubmit a patch
without the reordering: I’ve added more comments anyway as I’ve learned
more about this since yesterday. ;-)
Here it is!
--
Pierre-Marie de Rodat
>From 601dd0e949f4af456a11
On 09/14/2017 07:16 PM, Jeff Law wrote:
The comment additions are fine. What's the rationale behind the
ordering of the fields? In general we want the opposite order from what
you did -- going from most strictly aligned to least strictly aligned
minimizes the amount of unused padding.
Thank y
On 09/14/2017 02:01 AM, Pierre-Marie de Rodat wrote:
> Hello,
>
> This commit adds comments to fields in the cgraph_thunk_info structure
> declaration from cgraph.h. They will hopefully answer questions that
> people like myself can ask while discovering the thunk machinery. I
> also made an asse
