Hi H.,
On Mon, 15 Apr 2013, Han Shen(沈涵) wrote:
> Hi, I'm to bring up this patch about '-fstack-protector-strong' for trunk.
>
> Background - some times stack-protector is too-simple while
> stack-protector-all over-kills, for example, to build one of our core
> systems, we forcibly add "-fstack-
Updated patch according to Jeff Law's comments (
http://gcc.gnu.org/ml/gcc-patches/2013-05/msg00038.html )
Thanks,
H.
On Wed, Apr 17, 2013 at 11:40 AM, Han Shen(沈涵) wrote:
> Thanks.
>
> On Wed, Apr 17, 2013 at 2:26 AM, Florian Weimer wrote:
>> On 04/17/2013 02:49 AM, Han Shen wrote:
Indent
Thanks.
On Wed, Apr 17, 2013 at 2:26 AM, Florian Weimer wrote:
> On 04/17/2013 02:49 AM, Han Shen wrote:
>>> Indentation is off (unless both mail clients I tried are clobbering your
>>> patch). I think the GNU coding style prohibits the braces around the
>>> single-statement body of the outer 'f
On 04/17/2013 02:49 AM, Han Shen wrote:
+ if (flag_stack_protect == 3)
+cpp_define (pfile, "__SSP_STRONG__=3");
if (flag_stack_protect == 2)
cpp_define (pfile, "__SSP_ALL__=2");
3 and 2 should be replaced by SPCT_FLAG_STRONG and SPCT_FLAG_ALL.
I define these SPCT_FLAG_XXX in cfgex
Hi Florian, thanks for the review!
On Tue, Apr 16, 2013 at 6:32 AM, Florian Weimer wrote:
Please include the proposed changelog entries.
Done.
+ if (flag_stack_protect == 3)
+cpp_define (pfile, "__SSP_STRONG__=3");
if (flag_stack_protect == 2)
cpp_define (pfile, "__SSP_ALL__=2
On 04/15/2013 11:15 PM, Han Shen(沈涵) wrote:
Hi, I'm to bring up this patch about '-fstack-protector-strong' for trunk.
Background - some times stack-protector is too-simple while
stack-protector-all over-kills, for example, to build one of our core
systems, we forcibly add "-fstack-protector-all
Hi, any one got a chance to take look at this patch?
It seems that some other guys are also interested in this patch, the
clang developer is also proposing implement this
"-fstack-protect-strong" option.
Patch has just been merged with newest trunk and fixed a bug reported by Kees.
Tested fox x8
On Thu, 14 Jun 2012, shen...@google.com wrote:
> Hi, this is to port the patch from google/main to trunk, which provides
> a new stack protection option - "fstack-protector-strong".
If you are proposing a patch for trunk, please include the whole patch in
the gcc-patches posting.
> Detail -
> h
