Hi!
On 2019-12-17T00:00:04+0100, I wrote:
> On 2019-11-14T16:35:31+0100, Frederik Harwath
> wrote:
>> this patch implements OpenACC 2.6 "acc_get_property" and related functions.
> As I mentioned before ("thinking aloud"):
>
> | [...] 'acc_device_current' [is] relevant only for
> | 'acc_get_prop
Hi Thomas,
On 23.01.20 15:32, Thomas Schwinge wrote:
> On 2020-01-20T15:01:01+0100, "Harwath, Frederik"
> wrote:
>> On 16.01.20 17:00, Thomas Schwinge wrote:
>>> On 2019-12-20T17:46:57+0100, "Harwath, Frederik"
>>> wrote:
>> Ok to push the commit to master?
>
> Thanks, OK. Reviewed-by: Thom
Hi Frederik!
On 2020-01-20T15:01:01+0100, "Harwath, Frederik"
wrote:
> I have attached a patch containing the changes that you suggested.
> On 16.01.20 17:00, Thomas Schwinge wrote:
>> On 2019-12-20T17:46:57+0100, "Harwath, Frederik"
>> wrote:
> Ok to push the commit to master?
Thanks, OK.
Hi Thomas,
I have attached a patch containing the changes that you suggested.
On 16.01.20 17:00, Thomas Schwinge wrote:
> On 2019-12-20T17:46:57+0100, "Harwath, Frederik"
> wrote:
>> --- /dev/null
>> +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/acc_get_property-2.c
>
> I suggest to rename
Hi Frederik!
On 2019-12-20T17:46:57+0100, "Harwath, Frederik"
wrote:
> --- /dev/null
> +++ b/libgomp/testsuite/libgomp.oacc-c-c++-common/acc_get_property-2.c
I suggest to rename this one to 'acc_get_property-nvptx.c'.
> @@ -0,0 +1,68 @@
> +/* Test the `acc_get_property' and '`acc_get_property_
Hi!
On 2019-12-21T23:02:38+0100, I wrote:
> On 2019-12-20T17:46:57+0100, "Harwath, Frederik"
> wrote:
>>> > --- a/include/gomp-constants.h
>>> > +++ b/include/gomp-constants.h
>>> > +#define GOMP_DEVICE_CURRENT -3
>>> Should this actually get value '-1' instead of '-3'? Or, is th
Hi Thomas,
>> Is it ok to commit the patch to trunk?
>
> OK, thanks. And then some follow-up/clean-up next year, also including
> some of the open questions that I've snipped off here.
Right, thanks for the review! I have committed the patch as r279710 with a
minor change: I have disabled the n
Hi Frederik!
On 2019-12-20T17:46:57+0100, "Harwath, Frederik"
wrote:
>> | Before Frederik starts working on integrating this into GCC trunk, do you
>> | (Jakub) agree with the libgomp plugin interface changes as implemented by
>> | Maciej? For example, top-level 'GOMP_OFFLOAD_get_property' func
Hi Thomas,
thanks for the review! I have attached a revised patch.
> > There is no AMD GCN support yet. This will be added later on.
>
> ACK, just to note that there now is a 'libgomp/plugin/plugin-gcn.c' that
> at least needs to get a stub implementation (can mostly copy from
> 'libgomp/plugin/pl
On 16/12/2019 23:00, Thomas Schwinge wrote:
There is no AMD GCN support yet. This will be added later on.
ACK, just to note that there now is a 'libgomp/plugin/plugin-gcn.c' that
at least needs to get a stub implementation (can mostly copy from
'libgomp/plugin/plugin-hsa.c'?) as otherwise the b
Hi,
On Tue, Dec 17 2019, Thomas Schwinge wrote:
> On 2019-11-14T16:35:31+0100, Frederik Harwath
> wrote:
>> this patch implements OpenACC 2.6 "acc_get_property" and related functions.
>
> [...]
>
>> --- a/libgomp/plugin/plugin-hsa.c
>> +++ b/libgomp/plugin/plugin-hsa.c
>> @@ -699,6 +699,32 @@ GO
Hi Frederik!
On 2019-11-14T16:35:31+0100, Frederik Harwath wrote:
> this patch implements OpenACC 2.6 "acc_get_property" and related functions.
I'm attaching a version rebased on top of current GCC trunk, as well as
an incremental patch; please review these changes, and merge into yours.
> The
12 matches
Mail list logo
