Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Joel Brobecker
> > libiberty/ChangeLog: > > > > * d-demangle.c: Replace strtold with strtod in global comment. > > (strtold): Remove declaration. > > (strtod): New declaration. > > (dlang_parse_real): Declare value as double instead of long > > double. Replace call to strt

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Iain Buclaw
On 14 October 2014 18:07, Joel Brobecker wrote: >> I've just seen this, so I'll repeat what I've said in gdb patches too. >> >> The call to strtold is only needed to decode templates which have a >> floating point value encoded inside. This value may or may not have a >> greater than double precis

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Ian Lance Taylor
On Tue, Oct 14, 2014 at 10:07 AM, Joel Brobecker wrote: > > libiberty/ChangeLog: > > * d-demangle.c: Replace strtold with strtod in global comment. > (strtold): Remove declaration. > (strtod): New declaration. > (dlang_parse_real): Declare value as double instead of

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Joel Brobecker
> I've just seen this, so I'll repeat what I've said in gdb patches too. > > The call to strtold is only needed to decode templates which have a > floating point value encoded inside. This value may or may not have a > greater than double precision. > > Replacing long double with double will be f

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Iain Buclaw
On 14 October 2014 15:28, Ian Lance Taylor wrote: > On Tue, Oct 14, 2014 at 7:12 AM, Joel Brobecker wrote: >> >>> libiberty/ChangeLog >>> 2014-08-05 Iain Buclaw >>> >>> * Makefile.in (CFILES): Add d-demangle.c. >>> (REQUIRED_OFILES): Add d-demangle.o. >>> * cplus-dem.c (libiberty_d

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Ian Lance Taylor
On Tue, Oct 14, 2014 at 7:12 AM, Joel Brobecker wrote: > >> libiberty/ChangeLog >> 2014-08-05 Iain Buclaw >> >> * Makefile.in (CFILES): Add d-demangle.c. >> (REQUIRED_OFILES): Add d-demangle.o. >> * cplus-dem.c (libiberty_demanglers): Add dlang_demangling case. >> (cplus_demangl

Re: [PATCH] Add D demangling support to libiberty

2014-10-14 Thread Joel Brobecker
Hello Ian, > libiberty/ChangeLog > 2014-08-05 Iain Buclaw > > * Makefile.in (CFILES): Add d-demangle.c. > (REQUIRED_OFILES): Add d-demangle.o. > * cplus-dem.c (libiberty_demanglers): Add dlang_demangling case. > (cplus_demangle): Likewise. > * d-demangle.c: New file. >

Re: [PATCH] Add D demangling support to libiberty

2014-09-23 Thread Ian Lance Taylor
On Fri, Sep 19, 2014 at 12:51 AM, Iain Buclaw wrote: > On 4 August 2014 16:52, Ian Lance Taylor wrote: >> On Sun, Aug 3, 2014 at 11:12 AM, Iain Buclaw wrote: >>> >>> - I haven't signed any copyright assignments to GCC. But I have >>> papers from Donald ready to send across. >> >> Definitely nec

Re: [PATCH] Add D demangling support to libiberty

2014-09-23 Thread Iain Buclaw
On 19 September 2014 08:51, Iain Buclaw wrote: > On 4 August 2014 16:52, Ian Lance Taylor wrote: >> On Sun, Aug 3, 2014 at 11:12 AM, Iain Buclaw wrote: >>> >>> - I haven't signed any copyright assignments to GCC. But I have >>> papers from Donald ready to send across. >> >> Definitely necessary

Re: [PATCH] Add D demangling support to libiberty

2014-09-19 Thread Iain Buclaw
On 4 August 2014 16:52, Ian Lance Taylor wrote: > On Sun, Aug 3, 2014 at 11:12 AM, Iain Buclaw wrote: >> >> - I haven't signed any copyright assignments to GCC. But I have >> papers from Donald ready to send across. > > Definitely necessary before we can consider this. Please get this > squared

Re: [PATCH] Add D demangling support to libiberty

2014-08-05 Thread Iain Buclaw
Attached revision #2 of the patch. --- Add D demangling support for version 2 of the ABI. include/ChangeLog 2014-08-05 Iain Buclaw * demangle.h (DMGL_DLANG): New macro. (DMGL_STYLE_MASK): Add DMGL_DLANG. (demangling_styles): Add dlang_demangling. (DLANG_DEMANGLING_STYLE_STRING

Re: [PATCH] Add D demangling support to libiberty

2014-08-04 Thread Iain Buclaw
On 4 August 2014 17:06, Tom Tromey wrote: >> "Iain" == Iain Buclaw writes: > > Iain> This adds a demangler for the D programming language to libiberty, > Iain> intended to be used in GDB and Binutils. GDB already has a trimmed > Iain> down implementation of this, but have been advised that h

Re: [PATCH] Add D demangling support to libiberty

2014-08-04 Thread Iain Buclaw
On 4 August 2014 16:52, Ian Lance Taylor wrote: > On Sun, Aug 3, 2014 at 11:12 AM, Iain Buclaw wrote: >> >> This adds a demangler for the D programming language to libiberty, >> intended to be used in GDB and Binutils. GDB already has a trimmed >> down implementation of this, but have been advis

Re: [PATCH] Add D demangling support to libiberty

2014-08-04 Thread Tom Tromey
> "Iain" == Iain Buclaw writes: Iain> This adds a demangler for the D programming language to libiberty, Iain> intended to be used in GDB and Binutils. GDB already has a trimmed Iain> down implementation of this, but have been advised that here would be Iain> a better location to house it.

Re: [PATCH] Add D demangling support to libiberty

2014-08-04 Thread Ian Lance Taylor
On Sun, Aug 3, 2014 at 11:12 AM, Iain Buclaw wrote: > > This adds a demangler for the D programming language to libiberty, > intended to be used in GDB and Binutils. GDB already has a trimmed > down implementation of this, but have been advised that here would be > a better location to house it.