Re: [PATCH] Add -Wabsolute-value

2018-09-14 Thread Jeff Law
On 9/4/18 3:08 AM, Martin Jambor wrote: > Hi, > > On Fri, Aug 31 2018, Joseph Myers wrote: >> On Fri, 31 Aug 2018, Martin Jambor wrote: >> >>> diff --git a/gcc/common.opt b/gcc/common.opt >>> index ebc3ef43ce2..2950760fb2a 100644 >>> --- a/gcc/common.opt >>> +++ b/gcc/common.opt >>> @@ -815,6 +815

Re: [PATCH] Add -Wabsolute-value

2018-09-04 Thread Martin Jambor
Hi, On Fri, Aug 31 2018, Joseph Myers wrote: > On Fri, 31 Aug 2018, Martin Jambor wrote: > >> diff --git a/gcc/common.opt b/gcc/common.opt >> index ebc3ef43ce2..2950760fb2a 100644 >> --- a/gcc/common.opt >> +++ b/gcc/common.opt >> @@ -815,6 +815,10 @@ Wvector-operation-performance >> Common Var(w

Re: [PATCH] Add -Wabsolute-value

2018-08-31 Thread Joseph Myers
On Fri, 31 Aug 2018, Martin Jambor wrote: > diff --git a/gcc/common.opt b/gcc/common.opt > index ebc3ef43ce2..2950760fb2a 100644 > --- a/gcc/common.opt > +++ b/gcc/common.opt > @@ -815,6 +815,10 @@ Wvector-operation-performance > Common Var(warn_vector_operation_performance) Warning > Warn when

Re: [PATCH] Add -Wabsolute-value

2018-08-31 Thread Martin Jambor
Hi, thank you very much for your comments. On Fri, Aug 24 2018, Joseph Myers wrote: > On Fri, 24 Aug 2018, Martin Jambor wrote: > >> +/* Assuming we have encountered a call to a probably wrong kind of abs, >> issue a >> + warning. LOC is the location of the call, FNKIND is a string >> charac

Re: [PATCH] Add -Wabsolute-value

2018-08-24 Thread Joseph Myers
On Fri, 24 Aug 2018, Martin Jambor wrote: > +/* Assuming we have encountered a call to a probably wrong kind of abs, > issue a > + warning. LOC is the location of the call, FNKIND is a string > characterizing > + the class of the used abs function, FNDEC is the actual function > declaratio

Re: [PATCH] Add -Wabsolute-value

2018-08-24 Thread Martin Jambor
Hi On Wed, Aug 15 2018, Eric Gallager wrote: > On 8/14/18, Joseph Myers wrote: >> On Tue, 14 Aug 2018, Martin Jambor wrote: >> >>> when you try compiling a call to function abs and provide an unsigned >>> int in the argument in C++, you will get an error about ambiguous >>> overload. In C howeve