Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-12-06 Thread Markus Trippelsdorf
On 2012.11.29 at 11:26 -0800, H.J. Lu wrote: > On Thu, Nov 29, 2012 at 11:06 AM, Jakub Jelinek wrote: > > On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote: > >> On 11/29/2012 06:36 PM, Tobias Burnus wrote: > >> >H.J. Lu wrote: > >> >>This patch adds --with-build-config=bootstrap-asan

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-12-03 Thread H.J. Lu
On Mon, Dec 3, 2012 at 3:52 AM, Jakub Jelinek wrote: > Hi! > > On Thu, Nov 29, 2012 at 12:20:39PM -0800, H.J. Lu wrote: >> On Thu, Nov 29, 2012 at 11:06 AM, Jakub Jelinek wrote: >> > On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote: >> >> On 11/29/2012 06:36 PM, Tobias Burnus wrote:

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-12-03 Thread Jakub Jelinek
Hi! On Thu, Nov 29, 2012 at 12:20:39PM -0800, H.J. Lu wrote: > On Thu, Nov 29, 2012 at 11:06 AM, Jakub Jelinek wrote: > > On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote: > >> On 11/29/2012 06:36 PM, Tobias Burnus wrote: > >> >H.J. Lu wrote: > >> >>This patch adds --with-build-confi

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-11-29 Thread H.J. Lu
On Thu, Nov 29, 2012 at 11:06 AM, Jakub Jelinek wrote: > On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote: >> On 11/29/2012 06:36 PM, Tobias Burnus wrote: >> >H.J. Lu wrote: >> >>This patch adds --with-build-config=bootstrap-asan support. Tested on >> >>Linux/x86-64. OK to install?

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-11-29 Thread H.J. Lu
On Thu, Nov 29, 2012 at 11:06 AM, Jakub Jelinek wrote: > On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote: >> On 11/29/2012 06:36 PM, Tobias Burnus wrote: >> >H.J. Lu wrote: >> >>This patch adds --with-build-config=bootstrap-asan support. Tested on >> >>Linux/x86-64. OK to install?

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-11-29 Thread Andrew Pinski
On Thu, Nov 29, 2012 at 11:03 AM, H.J. Lu wrote: > On Thu, Nov 29, 2012 at 10:32 AM, H.J. Lu wrote: >> On Thu, Nov 29, 2012 at 10:24 AM, Paolo Carlini >> wrote: >>> On 11/29/2012 06:36 PM, Tobias Burnus wrote: H.J. Lu wrote: > > This patch adds --with-build-config=bootstrap-asa

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-11-29 Thread Jakub Jelinek
On Thu, Nov 29, 2012 at 07:24:38PM +0100, Paolo Carlini wrote: > On 11/29/2012 06:36 PM, Tobias Burnus wrote: > >H.J. Lu wrote: > >>This patch adds --with-build-config=bootstrap-asan support. Tested on > >>Linux/x86-64. OK to install? > > > >I think that patch has broken bootstrap for me. If I do

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-11-29 Thread H.J. Lu
On Thu, Nov 29, 2012 at 10:32 AM, H.J. Lu wrote: > On Thu, Nov 29, 2012 at 10:24 AM, Paolo Carlini > wrote: >> On 11/29/2012 06:36 PM, Tobias Burnus wrote: >>> >>> H.J. Lu wrote: This patch adds --with-build-config=bootstrap-asan support. Tested on Linux/x86-64. OK to install? >>

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-11-29 Thread H.J. Lu
On Thu, Nov 29, 2012 at 10:24 AM, Paolo Carlini wrote: > On 11/29/2012 06:36 PM, Tobias Burnus wrote: >> >> H.J. Lu wrote: >>> >>> This patch adds --with-build-config=bootstrap-asan support. Tested on >>> Linux/x86-64. OK to install? >> >> >> I think that patch has broken bootstrap for me. If I

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-11-29 Thread Paolo Carlini
On 11/29/2012 06:36 PM, Tobias Burnus wrote: H.J. Lu wrote: This patch adds --with-build-config=bootstrap-asan support. Tested on Linux/x86-64. OK to install? I think that patch has broken bootstrap for me. If I do a normal bootstrap, Stage1 fails with: libtool: compile: unrecognized opti

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-11-29 Thread Tobias Burnus
H.J. Lu wrote: Please try this: http://gcc.gnu.org/ml/gcc-patches/2012-11/msg01530.html I just did locally "git log -2 -p|patch -p1 -R" - and wait until you sort that out with the patch reviewers, which seemingly didn't like that patch. BTW: I am not sure whether it is possible with the cu

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-11-29 Thread H.J. Lu
On Thu, Nov 29, 2012 at 9:36 AM, Tobias Burnus wrote: > H.J. Lu wrote: >> >> This patch adds --with-build-config=bootstrap-asan support. Tested on >> Linux/x86-64. OK to install? > > > I think that patch has broken bootstrap for me. If I do a normal bootstrap, > Stage1 fails with: > > libtool: c

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-11-29 Thread Tobias Burnus
H.J. Lu wrote: This patch adds --with-build-config=bootstrap-asan support. Tested on Linux/x86-64. OK to install? I think that patch has broken bootstrap for me. If I do a normal bootstrap, Stage1 fails with: libtool: compile: unrecognized option `-D_GNU_SOURCE' libtool: compile: Try `libt

Re: [PATCH] Add --with-build-config=bootstrap-asan support

2012-11-29 Thread Jakub Jelinek
On Thu, Nov 22, 2012 at 12:37:47PM -0800, H.J. Lu wrote: > 2012-11-21 H.J. Lu > > * Makefile.def (target_modules): Add bootstrap=true and > raw_cxx=true to libsanitizer. > * configure.ac (bootstrap_target_libs): Add libsanitizer. > * Makefile.in: Regenerated. > * c

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-19 Thread H.J. Lu
On Mon, Nov 19, 2012 at 12:34 PM, Paolo Bonzini wrote: > On Mon, Nov 19, 2012 at 4:06 PM, H.J. Lu wrote: >> On Mon, Nov 19, 2012 at 12:01 AM, Paolo Bonzini wrote: >>> Il 19/11/2012 05:35, H.J. Lu ha scritto: On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini wrote: > Il 18/11/2012 00:54, H

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-19 Thread Paolo Bonzini
On Mon, Nov 19, 2012 at 4:06 PM, H.J. Lu wrote: > On Mon, Nov 19, 2012 at 12:01 AM, Paolo Bonzini wrote: >> Il 19/11/2012 05:35, H.J. Lu ha scritto: >>> On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini wrote: Il 18/11/2012 00:54, H.J. Lu ha scritto: > +@if gcc-bootstrap > +ifneq ($(fi

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-19 Thread H.J. Lu
On Mon, Nov 19, 2012 at 12:01 AM, Paolo Bonzini wrote: > Il 19/11/2012 05:35, H.J. Lu ha scritto: >> On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini wrote: >>> Il 18/11/2012 00:54, H.J. Lu ha scritto: +@if gcc-bootstrap +ifneq ($(filter bootstrap-asan,$(BUILD_CONFIG)),) +LIBASAN_LIB

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-19 Thread Martin Jambor
Hi, On Sat, Nov 17, 2012 at 03:54:41PM -0800, H.J. Lu wrote: > Hi, > > This patch adds --with-build-config=bootstrap-asan support. OK to > install? I suppose this should be also described in gcc/doc/install.texi? Thanks, Martin > > Thanks. > > > H.J. > --- > 2012-11-17 H.J. Lu > >

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-19 Thread Konstantin Serebryany
> Does -faddress-sanitizer add a CPP symbol that lets you work around it? > If not, it's a bug. If so, please make libcpp revert to the dump > algorithm if said symbol is defined. Do you mean, does asan compilation cause some special preprocessor symbol to be defined? No, asan compilation does

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-19 Thread Paolo Bonzini
Il 19/11/2012 05:35, H.J. Lu ha scritto: > On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini wrote: >> Il 18/11/2012 00:54, H.J. Lu ha scritto: >>> +@if gcc-bootstrap >>> +ifneq ($(filter bootstrap-asan,$(BUILD_CONFIG)),) >>> +LIBASAN_LIBS=-B$$r/prev-$(TARGET_SUBDIR)/libsanitizer/asan/.libs >>> +endi

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread H.J. Lu
On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini wrote: > Il 18/11/2012 00:54, H.J. Lu ha scritto: >> +@if gcc-bootstrap >> +ifneq ($(filter bootstrap-asan,$(BUILD_CONFIG)),) >> +LIBASAN_LIBS=-B$$r/prev-$(TARGET_SUBDIR)/libsanitizer/asan/.libs >> +endif >> +@endif gcc-bootstrap > > Do you need this

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, Paolo Bonzini wrote: > Il 18/11/2012 16:59, Hans-Peter Nilsson ha scritto: > > Nice, but I agree with the other poster that this'd IMHO be > > better as --enable-checking=asan (or actually, > > --enable-checking=all,asan). > > Yeah, that's a good thing to support too. However,

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread H.J. Lu
On Sun, Nov 18, 2012 at 7:59 AM, Hans-Peter Nilsson wrote: > On Sun, 18 Nov 2012, H.J. Lu wrote: >> On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini wrote: >> > Il 18/11/2012 00:54, H.J. Lu ha scritto: >> >> +@if gcc-bootstrap >> >> +ifneq ($(filter bootstrap-asan,$(BUILD_CONFIG)),) >> >> +LIBASAN_

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread Paolo Bonzini
Il 18/11/2012 16:59, Hans-Peter Nilsson ha scritto: > On Sun, 18 Nov 2012, H.J. Lu wrote: >> On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini wrote: >>> Il 18/11/2012 00:54, H.J. Lu ha scritto: +@if gcc-bootstrap +ifneq ($(filter bootstrap-asan,$(BUILD_CONFIG)),) +LIBASAN_LIBS=-B$$r/p

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread Hans-Peter Nilsson
On Sun, 18 Nov 2012, H.J. Lu wrote: > On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini wrote: > > Il 18/11/2012 00:54, H.J. Lu ha scritto: > >> +@if gcc-bootstrap > >> +ifneq ($(filter bootstrap-asan,$(BUILD_CONFIG)),) > >> +LIBASAN_LIBS=-B$$r/prev-$(TARGET_SUBDIR)/libsanitizer/asan/.libs > >> +endi

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread H.J. Lu
On Sun, Nov 18, 2012 at 7:28 AM, Paolo Bonzini wrote: > Il 18/11/2012 00:54, H.J. Lu ha scritto: >> +@if gcc-bootstrap >> +ifneq ($(filter bootstrap-asan,$(BUILD_CONFIG)),) >> +LIBASAN_LIBS=-B$$r/prev-$(TARGET_SUBDIR)/libsanitizer/asan/.libs >> +endif >> +@endif gcc-bootstrap > > Do you need this

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-18 Thread Paolo Bonzini
Il 18/11/2012 00:54, H.J. Lu ha scritto: > +@if gcc-bootstrap > +ifneq ($(filter bootstrap-asan,$(BUILD_CONFIG)),) > +LIBASAN_LIBS=-B$$r/prev-$(TARGET_SUBDIR)/libsanitizer/asan/.libs > +endif > +@endif gcc-bootstrap Do you need this to be here? POSTSTAGE1_*_EXPORT is only used when bootstrapping,

Re: PATCH: Add --with-build-config=bootstrap-asan support

2012-11-17 Thread Markus Trippelsdorf
On 2012.11.17 at 15:54 -0800, H.J. Lu wrote: > Hi, > > This patch adds --with-build-config=bootstrap-asan support. OK to > install? Wouldn't it make more sense to add an "--enable-checking=asan" option instead? -- Markus