Re: [PATCH] Account for devirtualization opportunities in inliner

2011-11-14 Thread Jan Hubicka
Hi, the patch is OK. Thanks! Honza

Re: [PATCH] Account for devirtualization opportunities in inliner

2011-11-08 Thread Maxim Kuvyrkov
Ping. -- Maxim Kuvyrkov www.trivialbugs.com On 28/10/2011, at 9:01 PM, Maxim Kuvyrkov wrote: > Jan, > > Attached is the updated patch. The only major change is the addition of > indirect_call_cost to size and time weights. I've set the size cost of > indirect call to 3, which is what I re

Re: [PATCH] Account for devirtualization opportunities in inliner

2011-10-28 Thread Maxim Kuvyrkov
Jan, Attached is the updated patch. The only major change is the addition of indirect_call_cost to size and time weights. I've set the size cost of indirect call to 3, which is what I remember calculating when I looked into costs couple of months ago: one call instruction for the call itself,

Re: [PATCH] Account for devirtualization opportunities in inliner

2011-10-27 Thread Maxim Kuvyrkov
On 20/10/2011, at 10:11 PM, Jan Hubicka wrote: > static clause_t > -evaluate_conditions_for_edge (struct cgraph_edge *e, bool inline_p) > +evaluate_conditions_vals_binfos_for_edge (struct cgraph_edge *e, > + bool inline_p, > +

Re: [PATCH] Account for devirtualization opportunities in inliner

2011-10-20 Thread Jan Hubicka
Hi, sorry for delayed review. I am still trying to get ipa-inline-analysis to behave well on real codebases and make my mind around how to get more advanced hints, like this one, into it. diff --git a/gcc/ipa-inline-analysis.c b/gcc/ipa-inline-analysis.c index bd4d2ea..5e88c2d 100644 --- a/gcc/i

Re: [PATCH] Account for devirtualization opportunities in inliner

2011-10-20 Thread Richard Guenther
On Wed, Oct 19, 2011 at 11:59 PM, Maxim Kuvyrkov wrote: > On 28/09/2011, at 4:56 PM, Maxim Kuvyrkov wrote: > >> Jan, >> >> The following patch starts a series of patches which improve >> devirtualization optimizations in GCC. >> >> This patch builds on ipa-cp.c and ipa-prop.c infrastructure for a

Re: [PATCH] Account for devirtualization opportunities in inliner

2011-10-19 Thread Maxim Kuvyrkov
On 28/09/2011, at 4:56 PM, Maxim Kuvyrkov wrote: > Jan, > > The following patch starts a series of patches which improve devirtualization > optimizations in GCC. > > This patch builds on ipa-cp.c and ipa-prop.c infrastructure for analyzing > parameters and jump functions and adds basic estimat