Re: [PATCH] AIX Build failure with default -std=gnu23.

Thank you everyone. I have pushed the changes. Thanks, Sangamesh On Mon, Dec 9, 2024 at 12:48 PM swamy sangamesh wrote: > Hi David, > > I don't have write privileges for GCC repo. > I have raised a request for write access and provided your email address > as approver. > Please approve the r

Re: [PATCH] AIX Build failure with default -std=gnu23.

Hi David, I don't have write privileges for GCC repo. I have raised a request for write access and provided your email address as approver. Please approve the request. Thanks, Sangamesh On Mon, Dec 9, 2024 at 3:17 AM David Edelsohn wrote: > This revised patch is okay. > > You are listed in t

Re: [PATCH] AIX Build failure with default -std=gnu23.

This revised patch is okay. You are listed in the FSF copyrights file for GCC GDB GLIBC BINUTILS, but do you have write privileges for the GCC repo? You are not listed in gcc/MAINTAINERS for write-after-approval. Thanks, David On Sun, Dec 8, 2024 at 10:49 AM swamy sangamesh wrote: > Thank you

Re: [PATCH] AIX Build failure with default -std=gnu23.

Thank you all for the review and comments. David, I have tested the changes against the latest master and ran default test cases. I have also built and ran the default test cases on RHEL9.0 ppc64le. Please let me know if any other testing needs to be covered. Please find the latest patch attached

Re: [PATCH] AIX Build failure with default -std=gnu23.

On Fri, Dec 6, 2024 at 2:17 PM Ian Lance Taylor wrote: > David Edelsohn writes: > > > On Fri, Dec 6, 2024 at 12:25 PM Rainer Orth > > > wrote: > > > >> Hi David, > >> > >> > No objection from me, but Ian is the maintainer of libiberty, so I'll > >> defer > >> > to him, especially about style an

Re: [PATCH] AIX Build failure with default -std=gnu23.

David Edelsohn writes: > On Fri, Dec 6, 2024 at 12:25 PM Rainer Orth > wrote: > >> Hi David, >> >> > No objection from me, but Ian is the maintainer of libiberty, so I'll >> defer >> > to him, especially about style and overall software engineering. >> > >> > The C23 change presumably will break

Re: [PATCH] AIX Build failure with default -std=gnu23.

Hi David, > No objection from me, but Ian is the maintainer of libiberty, so I'll defer > to him, especially about style and overall software engineering. > > The C23 change presumably will break on Alpha OSF/1 as well. Does GCC > still support OSF/1? It might be preferred to delete the block en

Re: [PATCH] AIX Build failure with default -std=gnu23.

On Fri, Dec 6, 2024 at 12:25 PM Rainer Orth wrote: > Hi David, > > > No objection from me, but Ian is the maintainer of libiberty, so I'll > defer > > to him, especially about style and overall software engineering. > > > > The C23 change presumably will break on Alpha OSF/1 as well. Does GCC >

Re: [PATCH] AIX Build failure with default -std=gnu23.

No objection from me, but Ian is the maintainer of libiberty, so I'll defer to him, especially about style and overall software engineering. The C23 change presumably will break on Alpha OSF/1 as well. Does GCC still support OSF/1? It might be preferred to delete the block entirely instead of #i

Re: [PATCH] AIX Build failure with default -std=gnu23.

swamy sangamesh writes: > Dear Community, > > Please let me know if the attached patch is fine. For such patches, I recommend CCing the maintainers of relevant components. In this case, that's David Edelsohn, being the AIX maintainer (done it for you here). I can't approve it but I imagine the

Re: [PATCH] AIX Build failure with default -std=gnu23.

Dear Community, Please let me know if the attached patch is fine. Thanks, Sangamesh On Tue, Dec 3, 2024 at 11:19 PM swamy sangamesh wrote: > Hi Eric, > > Thanks for the review. > > I too think removing the define is a better approach and seems these won't > be needed. > From the comment it loo

Re: [PATCH] AIX Build failure with default -std=gnu23.

Hi Eric, Thanks for the review. I too think removing the define is a better approach and seems these won't be needed. >From the comment it looks like that these were added long back and conflicting declarations were their until C23 standard uncovered it. If removing define is fine then i can sen

Re: [PATCH] AIX Build failure with default -std=gnu23.

On Mon, Dec 2, 2024 at 1:01 PM swamy sangamesh wrote: > > Dear Community, > > Please let me know your comment. > Or is it more appropriate to have changes with header guard like this ? > I personally think it's better to just remove the define, but if you're going to leave it in and guard it with

Re: [PATCH] AIX Build failure with default -std=gnu23.

Dear Community, Please let me know your comment. Or is it more appropriate to have changes with header guard like this ? --- a/libiberty/getopt.c +++ b/libiberty/getopt.c @@ -25,9 +25,11 @@ ^L /* This tells Alpha OSF/1 not to define a getopt prototype in . Ditto for AIX 3.2 and . */ +#ifnd