Re: [PATCH] AArch64: Improve inline memcpy expansion

2020-11-18 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra via Gcc-patches writes: >>> +  || (size <= (max_copy_size / 2) >>> +  && (aarch64_tune_params.extra_tuning_flags >>> +  & AARCH64_EXTRA_TUNE_NO_LDP_STP_QREGS))) >>> +    copy_bits = GET_MODE_BITSIZE (TImode); >> >> (Looks like the mailer has eaten some tabs here.) > > The em

Re: [PATCH] AArch64: Improve inline memcpy expansion

2020-11-16 Thread Wilco Dijkstra via Gcc-patches
Hi Richard, >> +  if (size <= 24 || !TARGET_SIMD > > Nit: one condition per line when the condition spans multiple lines. Fixed. >> +  || (size <= (max_copy_size / 2) >> +  && (aarch64_tune_params.extra_tuning_flags >> +  & AARCH64_EXTRA_TUNE_NO_LDP_STP_QREGS))) >> +    copy_bits = GET_M

Re: [PATCH] AArch64: Improve inline memcpy expansion

2020-11-11 Thread Richard Sandiford via Gcc-patches
Wilco Dijkstra writes: > Improve the inline memcpy expansion. Use integer load/store for copies <= 24 > bytes > instead of SIMD. Set the maximum copy to expand to 256 by default, except > that -Os or > no Neon expands up to 128 bytes. When using LDP/STP of Q-registers, also use > Q-register