Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-08 Thread Paulo Matos
On 07/03/14 09:03, Richard Biener wrote: Btw, can you check the attached as well? It makes sure all TUs have -fshort-double set consistently and it automatically enables it at link-time, not allowing to override the setting. If it works for you please check it in, too. (I can't really test it

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-07 Thread Richard Biener
On Fri, Mar 7, 2014 at 9:59 AM, Richard Biener wrote: > On Fri, Mar 7, 2014 at 12:29 AM, Paulo Matos wrote: >> On 06/03/14 11:19, Richard Biener wrote: >>> >>> On Wed, Mar 5, 2014 at 12:55 PM, Paulo Matos >>> wrote: On 05/03/2014 11:51, Richard Biener wrote: > > > On Wed, M

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-07 Thread Richard Biener
On Fri, Mar 7, 2014 at 12:29 AM, Paulo Matos wrote: > On 06/03/14 11:19, Richard Biener wrote: >> >> On Wed, Mar 5, 2014 at 12:55 PM, Paulo Matos >> wrote: >>> >>> On 05/03/2014 11:51, Richard Biener wrote: On Wed, Mar 5, 2014 at 12:43 PM, Dominique Dhumieres wrote:

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-06 Thread Paulo Matos
On 06/03/14 11:19, Richard Biener wrote: On Wed, Mar 5, 2014 at 12:55 PM, Paulo Matos wrote: On 05/03/2014 11:51, Richard Biener wrote: On Wed, Mar 5, 2014 at 12:43 PM, Dominique Dhumieres wrote: Revision 208312 causes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60427 Uhm. pointer co

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-06 Thread Paulo Matos
On 06/03/2014 11:19, Richard Biener wrote: I have reverted the patch for now. Richard. That's fine Richard, thanks. I got stuck with another issue in the meantime but I will look at it again very soon. -- Paulo Matos

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-06 Thread Richard Biener
On Wed, Mar 5, 2014 at 12:55 PM, Paulo Matos wrote: > On 05/03/2014 11:51, Richard Biener wrote: >> >> On Wed, Mar 5, 2014 at 12:43 PM, Dominique Dhumieres >> wrote: >>> >>> >>> Revision 208312 causes >>> >>> http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60427 >> >> >> Uhm. pointer comparison agai

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-05 Thread Paulo Matos
On 05/03/2014 11:51, Richard Biener wrote: On Wed, Mar 5, 2014 at 12:43 PM, Dominique Dhumieres wrote: Revision 208312 causes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60427 Uhm. pointer comparison against double_type_node ... I'd say we want to revert the patch. Paulo, please do that.

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-05 Thread Richard Biener
On Wed, Mar 5, 2014 at 12:43 PM, Dominique Dhumieres wrote: > > Revision 208312 causes > > http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60427 Uhm. pointer comparison against double_type_node ... I'd say we want to revert the patch. Paulo, please do that. Let's do the alternate approach of mark

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-05 Thread Dominique Dhumieres
Revision 208312 causes http://gcc.gnu.org/bugzilla/show_bug.cgi?id=60427 Also compiling the test gcc.dg/lto/pr55113 with -m32 gives an ICE FAIL: gcc.dg/lto/pr55113 c_lto_pr55113_0.o assemble, -flto -fshort-double -O0 (internal compiler error) internal compiler error: in layout_type, at stor

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-04 Thread Rainer Orth
"Paulo J. Matos" writes: > On 04/03/14 11:16, Richard Biener wrote: >> It works fine on i386 for me but fails on x86_64. Please add a >> >> /* { dg-skip-if "PR-you-open" { { x86_64-*-* i?86-*-* } && lp64 } { >> "*" } { "" } } */ >> >> to the testcase to avoid the regression in the testsuite. >>

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-04 Thread Paulo J. Matos
On 04/03/14 11:16, Richard Biener wrote: It works fine on i386 for me but fails on x86_64. Please add a /* { dg-skip-if "PR-you-open" { { x86_64-*-* i?86-*-* } && lp64 } { "*" } { "" } } */ to the testcase to avoid the regression in the testsuite. Apologies, you're right. I meant x86_64 fai

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-04 Thread Richard Biener
On Tue, Mar 4, 2014 at 12:02 PM, Paulo J. Matos wrote: > On 03/03/14 09:56, Richard Biener wrote: >> >> Index: gcc/c-family/c.opt >> === >> --- gcc/c-family/c.opt (revision 208249) >> +++ gcc/c-family/c.opt (working copy) >> @@ -114

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-04 Thread Paulo J. Matos
On 03/03/14 09:56, Richard Biener wrote: Index: gcc/c-family/c.opt === --- gcc/c-family/c.opt (revision 208249) +++ gcc/c-family/c.opt (working copy) @@ -1141,7 +1141,7 @@ C++ ObjC++ Optimization Var(flag_rtti) I Generate run tim

Re: [PATCH] [lto/55113] Fix use of -fshort-double with -flto for powerpc

2014-03-03 Thread Richard Biener
On Sat, Mar 1, 2014 at 11:23 PM, Paulo J. Matos wrote: > > This patch fixes lto/55113 for powerpc. > Combining -fshort-double with -flto is now working fine. > > I attach patch and testcase (unsure if testcase is in the right place). > Tested with target powerpc-abispe. > > > 2014-03-01 Paulo Mat