Re: [PATCH] [i386] Fix ICE in pass_rpad.

2021-09-18 Thread Jakub Jelinek via Gcc-patches
On Sat, Sep 18, 2021 at 03:56:42PM +0800, Hongtao Liu wrote: > > Wouldn't it be better to do: > > E_VOIDmode: > > gcc_assert (convert_p); > !convert_p, Must be typo :) Yes, sorry. > > > break; > > default: > > gcc_unreachable (); > > ? > Sur

Re: [PATCH] [i386] Fix ICE in pass_rpad.

2021-09-18 Thread Hongtao Liu via Gcc-patches
On Sat, Sep 18, 2021 at 3:31 PM Jakub Jelinek wrote: > > On Sat, Sep 18, 2021 at 11:09:32AM +0800, liuhongt wrote: > > Besides conversion instructions, pass_rpad also handles scalar > > sqrt/rsqrt/rcp/round instructions, while r12-3614 should only want to > > handle conversion instructions, so fix

Re: [PATCH] [i386] Fix ICE in pass_rpad.

2021-09-18 Thread Jakub Jelinek via Gcc-patches
On Sat, Sep 18, 2021 at 11:09:32AM +0800, liuhongt wrote: > Besides conversion instructions, pass_rpad also handles scalar > sqrt/rsqrt/rcp/round instructions, while r12-3614 should only want to > handle conversion instructions, so fix it. > > Bootstrapped and regtest on x86_64-linux-gnu{-m32,}