On Aug 22, 2017, at 11:53 AM, Daniel Santos wrote:
>
> OK, the problem is at line 4014 of gcc/Makefile.in:
>
> $(MAKE) TESTSUITEDIR="$(TESTSUITEDIR)"
> RUNTESTFLAGS="$(RUNTESTFLAGS)" \
>check-parallel-$* \
So, this is typical of sh scripting. Most kids don't quote and know
OK, the problem is at line 4014 of gcc/Makefile.in:
$(MAKE) TESTSUITEDIR="$(TESTSUITEDIR)"
RUNTESTFLAGS="$(RUNTESTFLAGS)" \
check-parallel-$* \
Even worse, one can inject arbitrary shell commands here, not that I can
think of a scenario where it would be an actual security
On 08/22/2017 12:32 PM, Mike Stump wrote:
> On Aug 22, 2017, at 10:32 AM, Daniel Santos wrote:
>>> I would suggest "escaped or quoted."
>>> The whole argument to RUNTESTFLAGS can be quoted in either single
>>> or double quotes and, AFAICT, so can the space-separated test
>>> names within it.
>> W
On 08/22/2017 12:32 PM, Mike Stump wrote:
> On Aug 22, 2017, at 10:32 AM, Daniel Santos wrote:
>>> I would suggest "escaped or quoted."
>>> The whole argument to RUNTESTFLAGS can be quoted in either single
>>> or double quotes and, AFAICT, so can the space-separated test
>>> names within it.
>> W
On Aug 22, 2017, at 10:44 AM, Daniel Santos wrote:
>
> OK, how's this one?
Ok.
On Aug 22, 2017, at 10:32 AM, Daniel Santos wrote:
>
>> I would suggest "escaped or quoted."
>> The whole argument to RUNTESTFLAGS can be quoted in either single
>> or double quotes and, AFAICT, so can the space-separated test
>> names within it.
>
> Well, mysteriously, double quotes do not wor
On 08/22/2017 10:58 AM, Martin Sebor wrote:
> On 08/21/2017 07:41 PM, Daniel Santos wrote:
>> It took me a while to figure out how to do this so I figured that it
>> should be
>> in the docs. OK for trunk?
>>
>> * doc/install.texi: Add more details on selecting multiple tests.
>
> Thank you!
On Aug 22, 2017, at 8:58 AM, Martin Sebor wrote:
>
> On 08/21/2017 07:41 PM, Daniel Santos wrote:
>> It took me a while to figure out how to do this so I figured that it should
>> be
>> in the docs. OK for trunk?
Oh, yeah, with the correction mentioned, Ok.
> On Aug 22, 2017, at 8:58 AM, Martin Sebor wrote:
>
> On 08/21/2017 07:41 PM, Daniel Santos wrote:
>> It took me a while to figure out how to do this so I figured that it should
>> be
>> in the docs. OK for trunk?
>>
>> * doc/install.texi: Add more details on selecting multiple tests.
>
On 08/21/2017 07:41 PM, Daniel Santos wrote:
It took me a while to figure out how to do this so I figured that it should be
in the docs. OK for trunk?
* doc/install.texi: Add more details on selecting multiple tests.
Thank you! It had taken me some time to figure this out.
+The fil
10 matches
Mail list logo
