Re: [PATCH] [MIPS] fix mips_prepend insn.

2012-02-03 Thread Liu
On Fri, Feb 3, 2012 at 3:59 PM, Fu, Chao-Ying wrote: > Liu [pro...@gmail.com] wrote: > >> OK, I get. >> But, sorry, my mips64dspr2 patch has be done... >> Should I summit it? > >  I just wonder what version of the MIPS64 DSP/DSPr2 spec that you > implemented.  Do you have a target CPU that has th

RE: [PATCH] [MIPS] fix mips_prepend insn.

2012-02-03 Thread Fu, Chao-Ying
Liu [pro...@gmail.com] wrote: > OK, I get. > But, sorry, my mips64dspr2 patch has be done... > Should I summit it? I just wonder what version of the MIPS64 DSP/DSPr2 spec that you implemented. Do you have a target CPU that has these MIPS64 DSP/DSPr2 instructions? My concern is that the late

Re: [PATCH] [MIPS] fix mips_prepend insn.

2012-02-02 Thread Liu
On Fri, Feb 3, 2012 at 12:40 PM, Fu, Chao-Ying wrote: > Richard Sandiford [rdsandif...@googlemail.com] wrote: > >> This pattern maps directly to __builtin_mips_prepend, which is defined >> to take and return an SI type, so :SI is the correct choice here. >> >> I agree it might be nice to have a fu

RE: [PATCH] [MIPS] fix mips_prepend insn.

2012-02-02 Thread Fu, Chao-Ying
Richard Sandiford [rdsandif...@googlemail.com] wrote: > This pattern maps directly to __builtin_mips_prepend, which is defined > to take and return an SI type, so :SI is the correct choice here. > > I agree it might be nice to have a function that operates on 64-bit > values for 64-bit targets tho

Re: [PATCH] [MIPS] fix mips_prepend insn.

2012-02-02 Thread Richard Sandiford
Liu writes: > diff --git a/gcc/config/mips/mips-dspr2.md b/gcc/config/mips/mips-dspr2.md > index 5ae902f..6853b9d 100644 > --- a/gcc/config/mips/mips-dspr2.md > +++ b/gcc/config/mips/mips-dspr2.md > @@ -345,7 +345,7 @@ > (set_attr "mode" "SI")]) > > (define_insn "mips_prepend" > - [(set (

Re: [PATCH] [MIPS] fix mips_prepend insn.

2012-02-01 Thread Liu
diff --git a/gcc/config/mips/mips-dspr2.md b/gcc/config/mips/mips-dspr2.mdindex 5ae902f..6853b9d 100644--- a/gcc/config/mips/mips-dspr2.md+++ b/gcc/config/mips/mips-dspr2.md@@ -345,7 +345,7 @@    (set_attr "mode""SI")])  (define_insn "mips_prepend"-  [(set (match_operand:SI 0 "register_operand"