Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-11 Thread Martin Jambor
Hi, On Fri, Nov 04, 2011 at 08:01:41AM -0700, Delesley Hutchins wrote: > Thanks for the suggestion. Unfortunately, knowing the original > declaration doesn't help me; I also need to know the original > arguments that were passed at the call site, before those arguments > were removed by ipa-sra.

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-04 Thread Delesley Hutchins
Thanks for the suggestion. Unfortunately, knowing the original declaration doesn't help me; I also need to know the original arguments that were passed at the call site, before those arguments were removed by ipa-sra. > (Of course, ipa-sra removes scalar parameters only when they are not > used i

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-04 Thread Martin Jambor
Hi, On Thu, Nov 03, 2011 at 09:09:24AM -0700, Delesley Hutchins wrote: > Let's try this again; perhaps I should learn to use e-mail. :-) > > This patch fixes an ICE caused when the ipa-sra optimization deletes > function arguments that are referenced from within a thread safety > attribute.  It

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Diego Novillo
On Thu, Nov 3, 2011 at 15:31, Delesley Hutchins wrote: > New patch with suggested changes incorporated.  Warning now on by > default, asserts put back if ipa-sra not enabled, and style fixes. Thanks. I only found two nits: (1) some comments need an extra space after the final '.', (b) diagnosti

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Delesley Hutchins
New patch with suggested changes incorporated. Warning now on by default, asserts put back if ipa-sra not enabled, and style fixes. -DeLesley On Thu, Nov 3, 2011 at 11:06 AM, Diego Novillo wrote: > On Thu, Nov 3, 2011 at 12:41, Delesley Hutchins wrote: >>> I wonder... how about disabling IPA

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Diego Novillo
On Thu, Nov 3, 2011 at 12:41, Delesley Hutchins wrote: >> I wonder... how about disabling IPA-SRA when annotalysis is enabled? > > That would certainly make my life a lot easier -- IPA-SRA is not > really compatible with annotalysis.  The only problem I can see   is > that people may be unhappy if

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Delesley Hutchins
> I wonder... how about disabling IPA-SRA when annotalysis is enabled? That would certainly make my life a lot easier -- IPA-SRA is not really compatible with annotalysis. The only problem I can see is that people may be unhappy if turning on annotalysis makes their code runs slower. We need a

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Diego Novillo
On Thu, Nov 3, 2011 at 12:09, Delesley Hutchins wrote: > Let's try this again; perhaps I should learn to use e-mail.  :-) Well, all you really need is upload-gcc-patch.py from http://gcc.gnu.org/wiki/rietveld. We have an internal copy, I'll send you the location. > This patch fixes an ICE cause

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Delesley Hutchins
Let's try this again; perhaps I should learn to use e-mail. :-) This patch fixes an ICE caused when the ipa-sra optimization deletes function arguments that are referenced from within a thread safety attribute.  It will attempt to detect this situation and recover gracefully.  Since a graceful re

Re: [PATCH] [Annotalysis] Fix ICE caused by ipa-sra optimization.

2011-11-03 Thread Diego Novillo
On Wed, Nov 2, 2011 at 16:48, Delesley Hutchins wrote: > This patch fixes an ICE caused when the ipa-sra optimization deletes > function arguments that are referenced from within a thread safety > attribute.  It will attempt to detect this situation and recover > gracefully.  Since a graceful reco